| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -78,6 +78,8 @@ def _process_self_data(self, data): | |
| def add_signal_handler(self, sig, callback, *args): | ||
| """Add a handler for a signal. UNIX only. | ||
|
|
||
| This method can only be called from the main thread. | ||
|
|
||
| Raise ValueError if the signal number is invalid or uncatchable. | ||
| Raise RuntimeError if there is a problem setting up the handler. | ||
| """ | ||
| Expand Down Expand Up | @@ -1232,10 +1234,15 @@ def close(self): | |
| self._callbacks.clear() | ||
| if self._saved_sighandler is not None: | ||
| handler = signal.getsignal(signal.SIGCHLD) | ||
| if handler != self._sig_chld: | ||
| # add_signal_handler() sets the handler to _sighandler_noop. | ||
| if handler != _sighandler_noop: | ||
| logger.warning("SIGCHLD handler was changed by outside code") | ||
| else: | ||
| loop = self._loop | ||
| # This clears the wakeup file descriptor if necessary. | ||
| loop.remove_signal_handler(signal.SIGCHLD) | ||
| signal.signal(signal.SIGCHLD, self._saved_sighandler) | ||
|
|
||
| self._saved_sighandler = None | ||
|
|
||
| def __enter__(self): | ||
| Expand All | @@ -1259,19 +1266,33 @@ def remove_child_handler(self, pid): | |
| return False | ||
|
|
||
| def attach_loop(self, loop): | ||
| """ | ||
| This registers the SIGCHLD signal handler. | ||
|
|
||
| This method can only be called from the main thread. | ||
| """ | ||
| # Don't save the loop but initialize itself if called first time | ||
| # The reason to do it here is that attach_loop() is called from | ||
| # unix policy only for the main thread. | ||
| # Main thread is required for subscription on SIGCHLD signal | ||
| if loop is None or self._saved_sighandler is not None: | ||
| return | ||
|
|
||
| self._loop = loop | ||
|
Comment thread
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityPart of why I was saying to remove this line is to honor the code comment 7 lines above: # Don't save the loop but initialize itself if called first time
Sorry, something went wrong.
All reactions
|
||
| self._saved_sighandler = signal.getsignal(signal.SIGCHLD) | ||
| if self._saved_sighandler is None: | ||
| self._saved_sighandler = signal.signal(signal.SIGCHLD, self._sig_chld) | ||
| if self._saved_sighandler is None: | ||
| logger.warning("Previous SIGCHLD handler was set by non-Python code, " | ||
| "restore to default handler on watcher close.") | ||
| self._saved_sighandler = signal.SIG_DFL | ||
| logger.warning("Previous SIGCHLD handler was set by non-Python code, " | ||
| "restore to default handler on watcher close.") | ||
| self._saved_sighandler = signal.SIG_DFL | ||
|
|
||
| # Set SA_RESTART to limit EINTR occurrences. | ||
| signal.siginterrupt(signal.SIGCHLD, False) | ||
| if self._callbacks: | ||
| warnings.warn( | ||
| 'A loop is being detached ' | ||
| 'from a child watcher with pending handlers', | ||
| RuntimeWarning) | ||
|
|
||
| # This also sets up the wakeup file descriptor. | ||
| loop.add_signal_handler(signal.SIGCHLD, self._sig_chld) | ||
|
|
||
| def _do_waitpid_all(self): | ||
| for pid in list(self._callbacks): | ||
| Expand Down Expand Up | @@ -1314,7 +1335,7 @@ def _do_waitpid(self, expected_pid): | |
| expected_pid, returncode) | ||
| loop.call_soon_threadsafe(callback, pid, returncode, *args) | ||
|
|
||
| def _sig_chld(self, signum, frame): | ||
| def _sig_chld(self, *args): | ||
| try: | ||
| self._do_waitpid_all() | ||
| except (SystemExit, KeyboardInterrupt): | ||
| Expand Down | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Fix rare cases with :class:`asyncio.MultiLoopChildWatcher` where the event | ||
| loop can fail to awaken in response to a :py:data:`SIGCHLD` signal. |
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality@aeros I would think through what should happen if either loop is None or self._saved_sighandler is not None. For example, the previous implementation didn't use the loop argument, so there is a risk that code will stop working for people who were passing loop=None.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.