Repository navigation
bpo-34689: Prevent sysconfig._parse_makefile from expanding $${variables} - #20439
lepaperwan wants to merge 4 commits into
Conversation
Sorry, something went wrong.
The sysconfig._parse_makefile function expanded $${} formatted text
if another variable was present in a value. This change splits values
on $$ before searching for variables to avoid that.
| value = value[:m.start()] + item + after | ||
| if "$" in after: | ||
| after = value[offset + m.end():] | ||
| value = value[:offset + m.start()] + item.replace('$', '$$') + after |
There was a problem hiding this comment.
Please limit lines to 79 characters.
Sorry, something went wrong.
| @@ -0,0 +1,2 @@ | |||
| Split strings prior to parsing in :func:`sysconfig._parse_makefile` so it | |||
There was a problem hiding this comment.
sysconfig._parse_makefile is not a documented function, so I don't think the func role should be used here.
Sorry, something went wrong.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Lib/sysconfig.py was turned into package. Could you please resolve conflicts?
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
Signed-off-by: Filipe Laíns <lains@riseup.net>
As described in [bpo-34689](https://www.bugs.python.org/issue34689), sysconfig._parse_makefile recognizes $${variable} as a variable to expand in the second half of the _parse_makefile function.
This pull-request aims to fix that by splitting strings on $$ before looking for variables in them and restoring the $$ in values that require more processing.
There is no change to the documentation as this is a bug-fix.
https://bugs.python.org/issue34689
Supersedes #9362