Repository navigation
[3.9] bpo-13097: ctypes: limit callback to 1024 arguments (GH-19914) - #20453
Merged
miss-islington merged 1 commit intoMay 27, 2020
Merged
miss-islington merged 1 commit into
miss-islington merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ctypes now raises an ArgumentError when a callback is invoked with more than 1024 arguments. The ctypes module allocates arguments on the stack in ctypes_callproc() using alloca(), which is problematic when large numbers of arguments are passed. Instead of a stack overflow, this commit raises an ArgumentError if more than 1024 parameters are passed. (cherry picked from commit 29a1384) Co-authored-by: Sean Gillespie <sean@swgillespie.me>
vstinner
approved these changes
May 27, 2020
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, good bot.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@swgillespie and @vstinner: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@swgillespie and @vstinner: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
Author
|
@swgillespie and @vstinner: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctypes now raises an ArgumentError when a callback
is invoked with more than 1024 arguments.
The ctypes module allocates arguments on the stack in
ctypes_callproc() using alloca(), which is problematic
when large numbers of arguments are passed. Instead
of a stack overflow, this commit raises an ArgumentError
if more than 1024 parameters are passed.
(cherry picked from commit 29a1384)
Co-authored-by: Sean Gillespie sean@swgillespie.me
https://bugs.python.org/issue13097