gh-84995: Run sys.interactivehook() on asyncio REPL startup by remilapeyre · Pull Request #20517 · python/cpython · GitHub

https://bugs.python.org/issue40818

Issue: Run sys.__interactivehook__ for asyncio REPLs #84995

@1st1 could you review?

@1st1 is anything missing in this PR?

All commit authors signed the Contributor License Agreement.

Hi @remilapeyre, Is this PR something you still wish to have open? If you would like to move it forward, we would need a signed CLA and merge conflicts resolved. Please close if you do not wish to continue working on this. Thanks.

Please sign CLA and resolve merge conflict. Thanks.

@remilapeyre Could you resolve the conflicts?

Looks like OP lost interest (or was never notified). I'll add "Pending" label, if there's no response in 30 days just close the PR.

@remilapeyre Please fix merge conflict.

Hello, I'm a bit short on time to contribute but will try to put aside some time in the coming weeks to revive the PRs

@willingc Can i leave this to you?

gh-116095 is a "re-do" of this PR on top of main (sorry, I don't have access to update this PR directly, but I have credited @remilapeyre as the original author)

I like the feature and I like the implementation, but I have a few suggestions to reduce the risk of accidentally breaking code that was relying on implementation details of site.py. (Note that I am fine with moving register_readline() to the toplevel scope in site.py.)

Technically, this function is the "interactive hook". The docstring should probably clarify that.

Also, even though it isn't documented, I think we should maintain a function named enablerlcompleter() which, when calls, does

sys.__interactivehook__ = register_readline

It's likely that someone, somewhere is relying on that function existing, and it's only 2-3 lines to keep them happy.

I added enablerlcompleter() back and changed the wording in the docstrings. Should I add enablerlcompleter() and register_readline() to the documentation?

Co-authored-by: Itamar Oren <itamarost@gmail.com>

Thanks! I'll merge it now. I wouldn't add more docs about this to site.rst, it's intentionally a bit vague.

…python#20517) This makes the asyncio REPL (`python -m asyncio`) more usable and similar to the regular REPL. This exposes register_readline() as a top-level function in site.py, but it's intentionally undocumented. Co-authored-by: Carol Willing <carolcode@willingconsulting.com> Co-authored-by: Itamar Oren <itamarost@gmail.com>

Run sys.__interactivehook__() on asyncio REPL startup

21bdbc4

remilapeyre requested review from 1st1 and asvetlov as code owners May 29, 2020 16:11

the-knights-who-say-ni added the CLA signed label May 29, 2020

bedevere-bot added the awaiting review label May 29, 2020

remilapeyre changed the title Run sys.__interactivehook__() on asyncio REPL startup bpo-40818: Run sys.__interactivehook__() on asyncio REPL startup May 29, 2020

ZackerySpytz reviewed May 31, 2020

View reviewed changes

Comment thread Lib/asyncio/__main__.py Outdated

Comment thread Misc/NEWS.d/next/Library/2020-05-29-18-08-54.bpo-40818.Ij8ffq.rst Outdated

Comment thread Misc/NEWS.d/next/Library/2020-05-29-18-08-54.bpo-40818.Ij8ffq.rst Outdated

Address review comments

988f215

remilapeyre mannequin mentioned this pull request Apr 10, 2022

Run sys.__interactivehook__ for asyncio REPLs #84995

Closed

AlexWaygood added the topic-asyncio label Jul 5, 2022

AlexWaygood closed this Jul 5, 2022

AlexWaygood reopened this Jul 5, 2022

ezio-melotti removed the CLA signed label Jul 13, 2022

willingc reviewed Apr 26, 2023

View reviewed changes

willingc added awaiting changes and removed awaiting review labels Apr 26, 2023

gvanrossum changed the title bpo-40818: Run sys.__interactivehook__() on asyncio REPL startup gh-84995: Run sys.__interactivehook__() on asyncio REPL startup Aug 23, 2023

gvanrossum added the pending The issue will be closed if no feedback is provided label Aug 23, 2023

Merge remote-tracking branch 'origin/main' into bpo-40818

c9d3bae

remilapeyre requested review from gvanrossum and kumaraditya303 as code owners September 28, 2023 12:47

remilapeyre requested a review from ZackerySpytz September 28, 2023 14:43

remilapeyre requested a review from willingc September 28, 2023 14:43

Merge branch 'main' into bpo-40818

c0cec13

willingc added awaiting change review awaiting core review and removed pending The issue will be closed if no feedback is provided awaiting changes awaiting change review labels Sep 28, 2023

itamaro mentioned this pull request Feb 29, 2024

gh-84995: Run sys.__interactivehook__() on asyncio REPL startup #116095

Closed

Merge origin/main into bpo-40818 (using imerge)

7e1e5bb

itamaro reviewed Feb 29, 2024

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2020-05-29-18-08-54.bpo-40818.Ij8ffq.rst Outdated

gvanrossum reviewed Feb 29, 2024

View reviewed changes

Rémi Lapeyre and others added 2 commits March 1, 2024 09:50

Improve wording in News

5f60485

Co-authored-by: Itamar Oren <itamarost@gmail.com>

Address code review comments

caaa7c7

remilapeyre requested a review from gvanrossum March 1, 2024 09:13

Use enablerlcompleter()

bd60988

gvanrossum approved these changes Mar 1, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 1, 2024

gvanrossum merged commit b5949ea into python:main Mar 1, 2024

bedevere-app Bot removed the awaiting merge label Mar 1, 2024

		def register_readline():
		"""Enable default readline configuration on interactive prompts.

gh-84995: Run sys.__interactivehook__() on asyncio REPL startup by remilapeyre · Pull Request #20517 · python/cpython · GitHub

Repository navigation

gh-84995: Run sys.__interactivehook__() on asyncio REPL startup - #20517

gh-84995: Run sys.__interactivehook__() on asyncio REPL startup#20517gvanrossum merged 8 commits intopython:mainpython/cpython:mainfrom remilapeyre:bpo-40818remilapeyre/cpython:bpo-40818Copy head branch name to clipboard

Conversation

remilapeyre commented May 29, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asvetlov commented Nov 26, 2020

Uh oh!

andriisoldatenko commented Jul 5, 2022

Uh oh!

ghost commented Jul 5, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

willingc commented Apr 26, 2023

Uh oh!

willingc left a comment

Choose a reason for hiding this comment

Uh oh!

furkanonder commented May 10, 2023

Uh oh!

gvanrossum commented Aug 23, 2023

Uh oh!

gvanrossum commented Aug 23, 2023

Uh oh!

remilapeyre commented Sep 28, 2023

Uh oh!

gvanrossum commented Sep 28, 2023

Uh oh!

itamaro commented Feb 29, 2024

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

remilapeyre Mar 1, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

gh-84995: Run sys.interactivehook() on asyncio REPL startup by remilapeyre · Pull Request #20517 · python/cpython · GitHub

gh-84995: Run sys.interactivehook() on asyncio REPL startup - #20517

gh-84995: Run sys.interactivehook() on asyncio REPL startup#20517
gvanrossum merged 8 commits into
python:mainfrom
remilapeyre:bpo-40818

remilapeyre commented May 29, 2020 •
edited by bedevere-bot
Loading

ghost commented Jul 5, 2022 •
edited by ghost
Loading