FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 by erlend-aasland · Pull Request #20530 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 - #20530

Merged
miss-islington merged 2 commits into
python:masterfrom
erlend-aasland:fix-issue-40810
Jan 4, 2021
ConversationCommits (2)ChecksFiles changed
Merged

bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15#20530
miss-islington merged 2 commits into
python:masterfrom
erlend-aasland:fix-issue-40810

Conversation

erlend-aasland commented May 30, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Ref. SQLite 3.7.15 changelog:
"Avoid invoking the sqlite3_trace() callback multiple times when a statement is automatically reprepared due to SQLITE_SCHEMA errors."

https://bugs.python.org/issue40810

Automerge-Triggered-By: GH:gvanrossum

erlend-aasland mentioned this pull request May 30, 2020
Closed
erlend-aasland changed the title bpo-40810: Require SQLite 3.7.15 bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 May 30, 2020
auvipy approved these changes Jun 3, 2020
View reviewed changes

auvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks good

erlend-aasland commented Nov 18, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner Would you mind taking a look at this?

vstinner commented Nov 18, 2020

Copy link
Copy Markdown
Member

Nope. I don't know the SQLite module.

erlend-aasland commented Jan 4, 2021

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka, would you mind reviewing this? Short description of the PR:

Ref. SQLite 3.7.15 changelog:
"Avoid invoking the sqlite3_trace() callback multiple times when a statement is automatically reprepared due to SQLITE_SCHEMA errors."

The PR adapts the trace callback test to expect this bug for SQLite versions prior to 3.7.15.

gvanrossum approved these changes Jan 4, 2021
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

erlend-aasland commented Jan 4, 2021

Copy link
Copy Markdown
Contributor Author

LGTM.

Thanks!

gvanrossum commented Jan 4, 2021

Copy link
Copy Markdown
Member

We can backport to 3.9 and 3.8 -- earlier is not possible due to maintenance status.

miss-islington merged commit f7f0ed5 into python:master Jan 4, 2021

miss-islington commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

erlend-aasland deleted the fix-issue-40810 branch January 4, 2021 23:16
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2021
bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 (pytho…
bb64325 
…nGH-20530)

Ref. [SQLite 3.7.15 changelog](https://sqlite.org/changes.htmlGH-version_3_7_15):
_"Avoid invoking the sqlite3_trace() callback multiple times when a statement is automatically reprepared due to SQLITE_SCHEMA errors."_
(cherry picked from commit f7f0ed5)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented Jan 4, 2021

Copy link
Copy Markdown

GH-24104 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2021
bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 (pytho…
ea75ff5 
…nGH-20530)

Ref. [SQLite 3.7.15 changelog](https://sqlite.org/changes.htmlGH-version_3_7_15):
_"Avoid invoking the sqlite3_trace() callback multiple times when a statement is automatically reprepared due to SQLITE_SCHEMA errors."_
(cherry picked from commit f7f0ed5)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented Jan 4, 2021

Copy link
Copy Markdown

GH-24105 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jan 4, 2021
bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 (GH-20530
0ccac5f 
)

Ref. [SQLite 3.7.15 changelog](https://sqlite.org/changes.htmlGH-version_3_7_15):
_"Avoid invoking the sqlite3_trace() callback multiple times when a statement is automatically reprepared due to SQLITE_SCHEMA errors."_
(cherry picked from commit f7f0ed5)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this pull request Jan 4, 2021
bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 (GH-20530
80e5732 
)

Ref. [SQLite 3.7.15 changelog](https://sqlite.org/changes.htmlGH-version_3_7_15):
_"Avoid invoking the sqlite3_trace() callback multiple times when a statement is automatically reprepared due to SQLITE_SCHEMA errors."_
(cherry picked from commit f7f0ed5)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 (pytho…
e3c7a53 
…nGH-20530)

Ref. [SQLite 3.7.15 changelog](https://sqlite.org/changes.html#version_3_7_15):
_"Avoid invoking the sqlite3_trace() callback multiple times when a statement is automatically reprepared due to SQLITE_SCHEMA errors."_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
berkerpeksag Awaiting requested review from berkerpeksag
+1 more reviewer
auvipy auvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL