This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/* Avoid reference cycles through the context chain.
This is O(chain length) but context chains are
usually very short. Sensitive readers may try
to inline the call to PyException_GetContext. */
if (exc_value != value) {
PyObject *o = exc_value, *context;
while ((context = PyException_GetContext(o))) {
Py_DECREF(context);
if (context == value) {
PyException_SetContext(o, NULL);
break;
}
o = context;
}
PyException_SetContext(value, exc_value);
if (value == exc_value) {
/* This exception is already on top of the stack. */
Py_DECREF(exc_value);
}
else {
Py_DECREF(exc_value);
/* Otherwise, push the new value on top. */
PyException_SetContext(value, exc_value);
/* Now we need to destroy any reference cycles that might
exist in the chain of contexts. Use Floyd's cycle-finding
algorithm to determine if the chain has a cycle or if it
reaches NULL. */
PyObject *tortoise = GET_CONTEXT(value);
PyObject *hare = GET_CONTEXT(GET_CONTEXT(value));
while (hare != NULL && hare != tortoise) {
tortoise = GET_CONTEXT(tortoise);
hare = GET_CONTEXT(GET_CONTEXT(hare));
}
if (hare != NULL) {
/* Making it here means there is a cycle.
Now find the _first_ self-intersection. */
tortoise = value;
while (tortoise != hare) {
tortoise = GET_CONTEXT(tortoise);
hare = GET_CONTEXT(hare);
}
/* Now hare is the first intersection.
We want to disconnect hare from its second predecessor.
For example:
A --> B --> C --> D --> E --> C --> ...
becomes
A --> B --> C --> D --> E --> NULL,
since C is the first intersection.
*/
PyObject *prev = hare, *next = GET_CONTEXT(hare);
while (next != hare) {
prev = next;
next = GET_CONTEXT(next);
}
PyException_SetContext(prev, NULL);
}
}
}
if (value != NULL && PyExceptionInstance_Check(value))
tb = PyException_GetTraceback(value);
Expand Down
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-25782: Do not hang when exception contexts form a cycle. #20539
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
bpo-25782: Do not hang when exception contexts form a cycle. #20539
Filter by extension
Viewed files
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing