FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] bpo-40854: Allow overriding sys.platlibdir via PYTHONPLATLIBDIR env-var (GH-20605) by vstinner · Pull Request #20725 · python/cpython · GitHub

Repository navigation

[3.9] bpo-40854: Allow overriding sys.platlibdir via PYTHONPLATLIBDIR env-var (GH-20605) - #20725

Merged
vstinner merged 1 commit into
python:3.9from
vstinner:platlibdir_env39
Jun 8, 2020
Merged

vstinner merged 1 commit into
python:3.9from
vstinner:platlibdir_env39

Conversation

vstinner commented Jun 8, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit 8f023a2)

https://bugs.python.org/issue40854

vstinner commented Jun 8, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member Author

bpo-1294959 added sys.platlibdir and configure --with-platlibdir to use /usr/lib64 on Fedora and SuSE to Python 3.9. The problem is that https://bugs.python.org/issue40854#msg370655 use case seems to be a regression compared to Python 3.9.

I now consider to backport the commit 8f023a2 to 3.9 since it looks like a fix part of bpo-1294959 rather than a bug fix.

I created this PR to backport PyConfig.platlibdir and PYTHONPLATLIBDIR env var to Python 3.9.

@ambv: Are you ok to include this change in Python 3.9 final?

cc @hroncok @mcepl @stratakis

vstinner commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

If this PR is merged, the documentation must be updated in the master branch to replace "3.9" with "3.10" (as I did in this backport).

ambv commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

I'm fine with this landing in 3.9.0 but unless it lands within the next hour or so it will miss Beta 2.

mcepl commented Jun 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

LGTM, but, boy, this is getting really complicated! Originally, it was just a simple few lines hack …

+1

vstinner merged commit 8175064 into python:3.9 Jun 8, 2020
vstinner deleted the platlibdir_env39 branch June 8, 2020 17:36

vstinner commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

LGTM, but, boy, this is getting really complicated! Originally, it was just a simple few lines hack …

A hack is acceptable for a downstream patch. But upstream, we usually write things differently and it requires more work. Also, when a feature is made upstream, new corner cases are discovered :-)

See also https://bugs.python.org/issue40684 "make install doesn't respect configure --with-platlibdir=lib64".

vstinner commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

I'm fine with this landing in 3.9.0 but unless it lands within the next hour or so it will miss Beta 2.

Ok, I merged my PR. Thanks @ambv ;-)

vstinner commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

If this PR is merged, the documentation must be updated in the master branch to replace "3.9" with "3.10" (as I did in this backport).

I created PR #20735.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL