FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40637: Do not emit warnings for disabled builtin hashes by stratakis · Pull Request #20937 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-40637: Do not emit warnings for disabled builtin hashes - #20937

Merged
miss-islington merged 1 commit into
python:masterfrom
stratakis:builtin_hashes_test_warnings
Jun 17, 2020
ConversationCommits (1)ChecksFiles changed
Merged

bpo-40637: Do not emit warnings for disabled builtin hashes#20937
miss-islington merged 1 commit into
python:masterfrom
stratakis:builtin_hashes_test_warnings

Conversation

stratakis commented Jun 17, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

test_hashlib emits some warnings when it cannot find some hashes
as it assumes they failed to compile. Since we can disable hashes
through configure, we emit the warnings only in the case that we
did not intentionaly disable them.

https://bugs.python.org/issue40637

Automerge-Triggered-By: @tiran

stratakis requested a review from tiran as a code owner June 17, 2020 13:55
bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jun 17, 2020

stratakis commented Jun 17, 2020

Copy link
Copy Markdown
Contributor Author

That is a test fix, thus I don't think a news entry is required here.

bpo-40637: Do not emit warnings for disabled builtin hashes
55aec53 
test_hashlib emits some warnings when it cannot find some hashes
as it assumes they failed to compile. Since we can disable hashes
through configure, we emit the warnings only in the case that we
did not intentionaly disable them.
stratakis force-pushed the builtin_hashes_test_warnings branch from 58418b9 to 55aec53 Compare June 17, 2020 14:00
tiran approved these changes Jun 17, 2020
View reviewed changes

tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

miss-islington commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

@stratakis: Status check is done, and it's a success ✅ .

miss-islington merged commit 236a0f5 into python:master Jun 17, 2020

miss-islington commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

Thanks @stratakis for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

Sorry @stratakis, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 236a0f5cf022b59dbb6ea17a8e7a677c573d39b9 3.9

miss-islington self-assigned this Jun 17, 2020
stratakis added a commit to stratakis/cpython that referenced this pull request Jun 17, 2020
[3.9] bpo-40637: Do not emit warnings for disabled builtin hashes (py…
6127ea1 
…thonGH-20937)

test_hashlib emits some warnings when it cannot find some hashes
as it assumes they failed to compile. Since we can disable hashes
through configure, we emit the warnings only in the case that we
did not intentionaly disable them.

Automerge-Triggered-By: @tiran
(cherry picked from commit 236a0f5)

Co-authored-by: stratakis <cstratak@redhat.com>

bedevere-bot commented Jun 17, 2020

Copy link
Copy Markdown

GH-20951 is a backport of this pull request to the 3.9 branch.

stratakis deleted the builtin_hashes_test_warnings branch June 17, 2020 19:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiran tiran approved these changes

Assignees

miss-islington

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL