bpo-40077: Convert _bz2 module to use PyType_FromSpec - #20960
Merged
corona10 merged 9 commits intoJun 19, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
corona10
commented
Jun 18, 2020
Comment thread
Lib/test/test_bz2.py
Outdated
corona10
marked this pull request as draft
June 18, 2020 13:15
Copy link
Copy Markdown
Member
|
I don't think that it should be possible to serialize a Compressor or Decompressor object. There is no getstate/setstate or reduce methods which would serialize attributes only accessible in C. More generally, I don't think that it would be useful, nor needed. |
Sorry, something went wrong.
vstinner
reviewed
Jun 18, 2020
Comment thread
Modules/_bz2module.c
Outdated
corona10
marked this pull request as ready for review
June 18, 2020 17:04
vstinner
reviewed
Jun 18, 2020
Comment thread
Modules/_bz2module.c
Outdated
vstinner
reviewed
Jun 19, 2020
Comment thread
Modules/_bz2module.c
vstinner
reviewed
Jun 19, 2020
vstinner
approved these changes
Jun 19, 2020
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40077