FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980) by tiran · Pull Request #20980 · python/cpython · GitHub

/ cpython Public

bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980) - #20980

Merged
tiran merged 1 commit into
python:masterfrom
tiran:bpo-40637-builtin-hash-stderr
Nov 17, 2020
ConversationCommits (1)ChecksFiles changed
Merged

bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980)#20980
tiran merged 1 commit into
python:masterfrom
tiran:bpo-40637-builtin-hash-stderr

Conversation

tiran commented Jun 19, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Skip testing of pure Python PBKDF2 when one or more builtin hash module
is not available. Otherwise the import of hashlib prints noise on
stderr.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue40637

bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jun 19, 2020

stratakis commented Jun 19, 2020

Copy link
Copy Markdown
Contributor

Without yet looking at the code, I can verify that this PR fixes the stderr noise on the RHEL8 FIPS enabled builbot and also clears the warning: Warning -- logging._handlerList was modified by test_hashlib

Also minor typo: s/hashses/hashes

stratakis commented Jun 19, 2020

Copy link
Copy Markdown
Contributor

Relevant buildbot: https://buildbot.python.org/all/#/builders/764/builds/150

bpo-40637: Don't test builtin PBKDF2 without builtin hashes
0866ed3 
Skip testing of pure Python PBKDF2 when one or more builtin hash module
is not available. Otherwise the import of hashlib prints noise on
stderr.

Signed-off-by: Christian Heimes <christian@python.org>
tiran changed the title bpo-40637: Don't test builtin PBKDF2 without builtin hashses bpo-40637: Don't test builtin PBKDF2 without builtin hashes Jun 20, 2020
tiran force-pushed the bpo-40637-builtin-hash-stderr branch from a5e11d5 to 0866ed3 Compare June 20, 2020 07:12

vstinner commented Jul 10, 2020

Copy link
Copy Markdown
Member

I have been asked to review this change. Honestly, I don't feel able to review this PR. I tried but failed to understand the complexity of hashlib build options and FIPS mode.

If you are confident and @stratakis confirms that this change fix his issue, just merge your PR.

tiran changed the title bpo-40637: Don't test builtin PBKDF2 without builtin hashes bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980) Nov 17, 2020
tiran merged commit 975022b into python:master Nov 17, 2020

miss-islington commented Nov 17, 2020

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

tiran deleted the bpo-40637-builtin-hash-stderr branch November 17, 2020 14:40
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2020
bpo-40637: Don't test builtin PBKDF2 without builtin hashes (pythonGH…
af3c717 
…-20980)

Skip testing of pure Python PBKDF2 when one or more builtin hash module
is not available. Otherwise the import of hashlib prints noise on
stderr.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 975022b)

Co-authored-by: Christian Heimes <christian@python.org>

bedevere-bot commented Nov 17, 2020

Copy link
Copy Markdown

GH-23343 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 17, 2020
bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980)
656d50f 
Skip testing of pure Python PBKDF2 when one or more builtin hash module
is not available. Otherwise the import of hashlib prints noise on
stderr.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 975022b)

Co-authored-by: Christian Heimes <christian@python.org>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-40637: Don't test builtin PBKDF2 without builtin hashes (pythonGH…
b63770d 
…-20980)

Skip testing of pure Python PBKDF2 when one or more builtin hash module
is not available. Otherwise the import of hashlib prints noise on
stderr.

Signed-off-by: Christian Heimes <christian@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
kk456852 kk456852 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL