Repository navigation
gh-78335: Improve tkinter widget docstrings - #21118
ZackerySpytz wants to merge 2 commits into
Conversation
Sorry, something went wrong.
Co-Authored-By: Noah Haasis <haasis_noah@yahoo.de>
|
This PR addresses the issues that were found in the old PR. |
Sorry, something went wrong.
terryjreedy
left a comment
There was a problem hiding this comment.
I checked the lists against https://www.tcl.tk/man/tcl8.6/TkCmd/contents.htm. I assumed 'bg' and 'fg' are valid even when not listed there.
Serhiy, do you want to separately review, or should I merge after corrections.
Sorry, something went wrong.
| fg, font, foreground, highlightbackground, highlightcolor, | ||
| highlightthickness, insertbackground, insertborderwidth, | ||
| insertofftime, insertontime, insertwidth, invalidcommand, | ||
| invcmd, justify, readonlybackground, relief, selectbackground, |
There was a problem hiding this comment.
The tk docs do not list 'invcmd' but do list 'vcmd'. So I will presume without conrary evidence that this is either missing from the tk doc or is added by tkinter.
Sorry, something went wrong.
There was a problem hiding this comment.
invcmd is an alias of invalidcommand and vcmd is an alias of validatecommand.
Sorry, something went wrong.
| activebackground, activeforeground, anchor, | ||
| background, bitmap, borderwidth, cursor, | ||
| disabledforeground, font, foreground, | ||
| background, bitmap, borderwidth, compound, |
There was a problem hiding this comment.
tk docs include bg, even though they do not for many of widgets above.
| background, bitmap, borderwidth, compound, | |
| background, bg, bitmap, borderwidth, compound, |
Sorry, something went wrong.
| insertborderwidth, insertofftime, | ||
| insertontime, insertwidth, padx, pady, | ||
| relief, selectbackground, | ||
| background, blockcursor, borderwidth, |
There was a problem hiding this comment.
The list of standard options was correct. The 6 additions
blockcursor, endline (spelled correctly), inactiveselectbackground, insertunfocused, startline, tabstyle,
should be moved to WIDGET-SPECIFIC OPTIONS
Sorry, something went wrong.
|
|
||
| background, borderwidth, cursor, height, | ||
| orient, relief, width | ||
| orient, proxybackground, proxyborderwidth, |
There was a problem hiding this comment.
height and width were misplaced as standard. They and the 3 new proxy... options should be moved down.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
|
Thanks @ZackerySpytz and @noahhaasis. The tkinter docstring option lists were since completed in gh-78335 by #152485; the current docstrings already cover everything this PR adds, with correct spellings and Tk 9.1+ annotations. Closing as superseded. |
Sorry, something went wrong.
Co-Authored-By: Noah Haasis haasis_noah@yahoo.de
https://bugs.python.org/issue34154