FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41171: Added method "PyMetaType_FromSpec" to allow for specifying the metaclass for the type. by WildCard65 · Pull Request #21238 · python/cpython · GitHub

/ cpython Public

bpo-41171: Added method "PyMetaType_FromSpec" to allow for specifying the metaclass for the type. - #21238

Closed
WildCard65 wants to merge 7 commits into
python:mainfrom
WildCard65:bpo-41171
ConversationCommits (7)ChecksFiles changed
Closed

bpo-41171: Added method "PyMetaType_FromSpec" to allow for specifying the metaclass for the type.#21238
WildCard65 wants to merge 7 commits into
python:mainfrom
WildCard65:bpo-41171

Conversation

WildCard65 commented Jun 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

WildCard65 requested a review from a team as a code owner June 30, 2020 16:29

WildCard65 commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

Paging @vstinner for review.

vstinner reviewed Jun 30, 2020
View reviewed changes
Comment thread Objects/typeobject.c Outdated

vstinner Jun 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I propose the name PyMetaType_FromSpec and remove PyMetaType_FromSpecWithBases.

WildCard65 Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So, you're suggesting renaming PyMetaType_FromSpecWithBases to just PyMetaType_FromSpec or just keeping the PyMetaType_FromSpec from above?

vstinner Jun 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rename PyMetaType_FromModuleAndSpec (4 parameters) to PyMetaType_FromSpec. And so remove the other PyMetaType_FromSpec (2 parameters).

WildCard65 Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should I move the method out of "Py_LIMITED_API" then?

WildCard65 and others added 2 commits June 30, 2020 16:58
Removed 'PyMetaType_FromSpecAndBases'.
745387c 
Added a note about 'PyMetaType_FromModuleAndSpec' in regards to 'tp_new'.
📜🤖 Added by blurb_it.
e2cde2c
WildCard65 requested review from vstinner and removed request for a team June 30, 2020 21:01

WildCard65 commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner I performed the change you requested.

WildCard65 changed the title bpo-41171: Added companion "FromSpec" methods prefixed with "PyMetaTy… bpo-41171: Added method "PyMetaType_FromSpec" to allow for specifying the metaclass for the type. Jun 30, 2020
WildCard65 mannequin mentioned this pull request Nov 30, 2022
Closed

kumaraditya303 commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Superseded by #93012

WildCard65 deleted the bpo-41171 branch November 30, 2022 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL