bpo-1635741: Release Unicode interned strings at exit - #21269
Merged
vstinner merged 1 commit intoJul 1, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* PyUnicode_InternInPlace() now ensures that interned strings are ready. * Add _PyUnicode_ClearInterned(). * Py_Finalize() now releases Unicode interned strings: call _PyUnicode_ClearInterned().
Copy link
Copy Markdown
Member
Author
|
Python has between 1446 (./python -sSI -c pass command) and 4660 (run 19 tests using ./python -m test and interrupt it after around 19 tests) interned strings at exit. This PR has no significant impact on timing of the ./python -sSI -c pass command: # benchmark $ python3 -m pyperf command -o ref.json -- ./python -sSI -c pass # switch to the PR branch, make $ python3 -m pyperf command -o clear.json -- ./python -sSI -c pass $ python3 -m pyperf show ref.json Mean +- std dev: 7.56 ms +- 0.24 ms $ python3 -m pyperf compare_to ref.json clear.json Benchmark hidden because not significant (1): command @shihai1991 proposed PR #21087 to solve the same problem. My PR clears interned strings before calling _PyDict_Fini() and _PyList_Fini(), since _PyUnicode_ClearInterned() uses a dict and a list. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ready.
call _PyUnicode_ClearInterned().
https://bugs.python.org/issue1635741