FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-26205: Specify the number of nested scopes by nanjekyejoannah · Pull Request #21324 · python/cpython · GitHub

/ cpython Public

bpo-26205: Specify the number of nested scopes - #21324

Merged
nanjekyejoannah merged 2 commits into
python:masterfrom
nanjekyejoannah:issue26205
Jul 6, 2020
ConversationCommits (2)ChecksFiles changed
Merged

bpo-26205: Specify the number of nested scopes#21324
nanjekyejoannah merged 2 commits into
python:masterfrom
nanjekyejoannah:issue26205

Conversation

nanjekyejoannah commented Jul 5, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jul 5, 2020
terryjreedy requested changes Jul 6, 2020
View reviewed changes

terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I approve with the requested change.

Comment thread Doc/tutorial/classes.rst Outdated

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Indicate 3 or 4
54ab7a6 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

terryjreedy commented Jul 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Please merge and backport with a changed ('activated') title, as I discussed on #21340.

nanjekyejoannah changed the title bpo-26205: Inconsistency concerning nested scopes bpo-26205: Specify number of nested scopes Jul 6, 2020
nanjekyejoannah changed the title bpo-26205: Specify number of nested scopes bpo-26205: Specify the number of nested scopes Jul 6, 2020
nanjekyejoannah merged commit 9ed3cd8 into python:master Jul 6, 2020

miss-islington commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2020
bpo-26205: Specify the number of nested scopes (pythonGH-21324)
f43eee8 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 9ed3cd8)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

GH-21341 is a backport of this pull request to the 3.9 branch.

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

GH-21342 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2020
bpo-26205: Specify the number of nested scopes (pythonGH-21324)
b5dc5ea 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 9ed3cd8)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>

nanjekyejoannah commented Jul 6, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the review @terryjreedy

nanjekyejoannah added a commit that referenced this pull request Jul 6, 2020
bpo-26205: Specify the number of nested scopes (GH-21324) (GH-21342)
7ceb3e3 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 9ed3cd8)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
nanjekyejoannah added a commit that referenced this pull request Jul 6, 2020
bpo-26205: Specify the number of nested scopes (GH-21324) (GH-21341)
3f4a9fd 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 9ed3cd8)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jul 6, 2020
bpo-26205: Specify the number of nested scopes (pythonGH-21324)
a085bc2 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
RoscoeRHiggins mannequin mentioned this pull request Oct 29, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL