FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41215: Don't use NULL by default in the PEG parser keyword list by pablogsal · Pull Request #21355 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-41215: Don't use NULL by default in the PEG parser keyword list - #21355

Merged
miss-islington merged 2 commits into
python:masterfrom
pablogsal:bpo-41215
Jul 6, 2020
ConversationCommits (2)ChecksFiles changed
Merged

bpo-41215: Don't use NULL by default in the PEG parser keyword list#21355
miss-islington merged 2 commits into
python:masterfrom
pablogsal:bpo-41215

Conversation

pablogsal commented Jul 6, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

pablogsal requested a review from lysnikolaou as a code owner July 6, 2020 18:35
lysnikolaou reviewed Jul 6, 2020
View reviewed changes
Comment thread Parser/pegen.c
Update Misc/NEWS.d/next/Core and Builtins/2020-07-06-18-36-33.bpo-412…
6689654 
…15.vFGFIz.rst

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

pablogsal commented Jul 6, 2020

Copy link
Copy Markdown
Member Author

@lysnikolaou Wanna land this one and the other yourself 😉 ?

lysnikolaou commented Jul 6, 2020

Copy link
Copy Markdown
Member

@lysnikolaou Wanna land this one and the other yourself 😉 ?

I was kinda hoping you'd say that! Let me try the automerge label this time.

lysnikolaou commented Jul 6, 2020

Copy link
Copy Markdown
Member

We should remove the needs backport to 3.9 label, since we don't need the automatic backport, right?

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

GH-21356 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit that referenced this pull request Jul 6, 2020
[3.9] bpo-41215: Don't use NULL by default in the PEG parser keyword …
54f115d 
…list (GH-21355) (GH-21356)

(cherry picked from commit 39e76c0)

Co-authored-by: Pablo Galindo <pablogsal@gmail.com>

Automerge-Triggered-By: @lysnikolaou

miss-islington commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

@pablogsal: Status check is done, and it's a success ✅ .

miss-islington merged commit 1ac0cbc into python:master Jul 6, 2020

lysnikolaou commented Jul 6, 2020

Copy link
Copy Markdown
Member

Worked like a charm.

pablogsal commented Jul 6, 2020

Copy link
Copy Markdown
Member Author

Worked like a charm.

Awesome 🎉

pablogsal deleted the bpo-41215 branch May 19, 2021 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lysnikolaou lysnikolaou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL