FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41219: Add audio/webm in mimetypes by cereblanco · Pull Request #21368 · python/cpython · GitHub

/ cpython Public

bpo-41219: Add audio/webm in mimetypes - #21368

Closed
cereblanco wants to merge 1 commit into
python:masterfrom
cereblanco:bpo_41219_add_audio_webm_in_mimetypes
Closed

bpo-41219: Add audio/webm in mimetypes#21368
cereblanco wants to merge 1 commit into
python:masterfrom
cereblanco:bpo_41219_add_audio_webm_in_mimetypes

Conversation

cereblanco commented Jul 6, 2020
edited
Loading

Copy link
Copy Markdown

bpo-41219: Add audio/webm in mimetypes

https://bugs.python.org/issue41219

cereblanco requested a review from a team as a code owner July 6, 2020 23:44

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@cereblanco

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Copy Markdown
Author

You can check yourself to see if the CLA has been received.

hello! i just signed but not received/approved yet.

cereblanco force-pushed the bpo_41219_add_audio_webm_in_mimetypes branch 2 times, most recently from 979389a to 20d5ce3 Compare July 7, 2020 00:22
cereblanco force-pushed the bpo_41219_add_audio_webm_in_mimetypes branch from 20d5ce3 to 960d286 Compare July 7, 2020 00:26

eamanu left a comment
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, I don't know mimetypes.py, but just adding this line, it's enough?

cereblanco commented Jul 7, 2020
edited
Loading

Copy link
Copy Markdown
Author

Sorry, I don't know mimetypes.py, but just adding this line, it's enough?

yes, it is added in the dictionary of _types_map_default, which is iterated upon initialization, such that each item will be added as mime type.

cereblanco closed this Jul 7, 2020
cereblanco reopened this Jul 7, 2020

Copy link
Copy Markdown
Author

Closing this PR. audio/webm also has the same extension as video/webm. Might do it in another PR.

cereblanco closed this Jul 7, 2020
cereblanco deleted the bpo_41219_add_audio_webm_in_mimetypes branch July 7, 2020 06:32
cereblanco restored the bpo_41219_add_audio_webm_in_mimetypes branch July 7, 2020 06:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL