bpo-41341: Recursive evaluation of ForwardRef in get_type_hints by wyfo · Pull Request #21553 · python/cpython · GitHub

The issue raised by recursive evaluation is infinite recursion with
recursive types. In that case, only the first recursive ForwardRef is
evaluated.

https://bugs.python.org/issue41341

The issue raised by recursive evaluation is infinite recursion with recursive types. In that case, only the first recursive ForwardRef is evaluated.

@isidentical This might help moving https://bugs.python.org/issue38605 forward (make from __future__ import annotations the default).

@ambv Assuming we get this to work, what would you think of backporting it to 3.9, even though beta5 is already released? On the one hand it's awfully late for such a change (and experience with the bpo issue above suggests it's not painful). On the other hand getting the same behavior for forward refs in 3.9 with from __future__ import annotations as it will have in 3.10 (regardless of that import) seems useful.

I was about to approve this PR when I realized that we should make this work with list -- I tried and it doesn't currently.

You're right concerning the fact that it doesn't work with list, but I've found that it's not related to this PR; actually, I think there is a significant defect in current PEP 585 implementation. In fact:

from dataclasses import dataclass, field
from typing import get_type_hints, List, ForwardRef

@dataclass
class Node:
    children: list["Node"] = field(default_factory=list)
    children2: List["Node"] = field(default_factory=list)

assert get_type_hints(Node) == {"children": list["Node"], "children2": List[Node]}
assert List["Node"].__args__ == (ForwardRef("Node"),)
assert list["Node"].__args__ == ("Node",)  # No ForwardRef here, so no evaluation by get_type_hints

I will open an issue on bugs.python.org to discuss about this, because I think this PR is not the best place to do it.

Heh, you're right, thanks for the analysis. We probably will not ever support this: importing ForwardRef from the built-in generic alias code would be problematic, and once from __future__ import annotations is always on there's no need to quote the argument anyway. Sorry for the hiccup. I will now approve your PR.

@isidentical This might help moving https://bugs.python.org/issue38605 forward (make from future import annotations the default).

I had my own implementations, but I think I am going to rebase because it was kind of a workaround.

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@ambv @pablogsal can I please have a decision on whether to backport this to 3.9? See my previous comment.

@ambv @pablogsal can I please have a decision on whether to backport this to 3.9? See my previous comment.

I think it makes sense, but being this 3.9 this is @ambv's decision

Thanks @wyfo for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

…onGH-21553) The issue raised by recursive evaluation is infinite recursion with recursive types. In that case, only the first recursive ForwardRef is evaluated. (cherry picked from commit 653f420) Co-authored-by: wyfo <joperez@hotmail.fr>

GH-21629 is a backport of this pull request to the 3.9 branch.

…1553) The issue raised by recursive evaluation is infinite recursion with recursive types. In that case, only the first recursive ForwardRef is evaluated. (cherry picked from commit 653f420) Co-authored-by: wyfo <joperez@hotmail.fr>

…on#21553) The issue raised by recursive evaluation is infinite recursion with recursive types. In that case, only the first recursive ForwardRef is evaluated.

…f or str Related: python/cpython#21553 (comment) Signed-off-by: John Andersen <johnandersenpdx@gmail.com>

recursive_guard argument was added in python/cpython#21553

…f or str Related: python/cpython#21553 (comment) Signed-off-by: John Andersen <johnandersenpdx@gmail.com>

bpo-41341: Recursive evaluation of ForwardRef in get_type_hints

2389c25

The issue raised by recursive evaluation is infinite recursion with recursive types. In that case, only the first recursive ForwardRef is evaluated.

wyfo requested review from gvanrossum and ilevkivskyi as code owners July 20, 2020 01:37

This comment has been minimized.

Sign in to view

the-knights-who-say-ni added the CLA not signed label Jul 20, 2020

bedevere-bot added the awaiting review label Jul 20, 2020

📜🤖 Added by blurb_it.

0a29c8b

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jul 20, 2020

gvanrossum reviewed Jul 21, 2020

View reviewed changes

gvanrossum approved these changes Jul 22, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jul 22, 2020

gvanrossum merged commit 653f420 into python:master Jul 22, 2020

bedevere-bot removed the awaiting merge label Jul 22, 2020

ambv added the needs backport to 3.9 label Jul 26, 2020

bedevere-bot removed the needs backport to 3.9 label Jul 26, 2020

johnandersen777 pushed a commit to johnandersen777/dffml that referenced this pull request Jun 2, 2022

util: python: is_forward_ref_dataclass: Helper to check for ForwardRe…

781f0c4

…f or str Related: python/cpython#21553 (comment) Signed-off-by: John Andersen <johnandersenpdx@gmail.com>

johnandersen777 pushed a commit to johnandersen777/dffml that referenced this pull request Jun 23, 2022

util: python: is_forward_ref_dataclass: Helper to check for ForwardRe…

dbb7c17

…f or str Related: python/cpython#21553 (comment) Signed-off-by: John Andersen <johnandersenpdx@gmail.com>

johnandersen777 pushed a commit to johnandersen777/dffml that referenced this pull request Jun 23, 2022

util: python: is_forward_ref_dataclass: Helper to check for ForwardRe…

1d2821f

…f or str Related: python/cpython#21553 (comment) Signed-off-by: John Andersen <johnandersenpdx@gmail.com>

johnandersen777 pushed a commit to intel/dffml that referenced this pull request Jul 7, 2022

util: python: is_forward_ref_dataclass: Helper to check for ForwardRe…

fc2b052

…f or str Related: python/cpython#21553 (comment) Signed-off-by: John Andersen <johnandersenpdx@gmail.com>

johnandersen777 pushed a commit to intel/dffml that referenced this pull request Jul 7, 2022

util: python: is_forward_ref_dataclass: Helper to check for ForwardRe…

ca4fb6b

…f or str Related: python/cpython#21553 (comment) Signed-off-by: John Andersen <johnandersenpdx@gmail.com>

aronbierbaum mentioned this pull request Aug 23, 2022

Update ForwardRef._evaluate for Python 3.11 python/typeshed#8600

Merged

hauntsaninja pushed a commit to python/typeshed that referenced this pull request Aug 24, 2022

Update ForwardRef._evaluate for Python 3.11 (#8600 )

ef6baca

recursive_guard argument was added in python/cpython#21553

johnandersen777 pushed a commit to johnandersen777/dffml that referenced this pull request Jan 5, 2023

util: python: is_forward_ref_dataclass: Helper to check for ForwardRe…

8fcff78

…f or str Related: python/cpython#21553 (comment) Signed-off-by: John Andersen <johnandersenpdx@gmail.com>

bpo-41341: Recursive evaluation of ForwardRef in get_type_hints by wyfo · Pull Request #21553 · python/cpython · GitHub

Repository navigation

bpo-41341: Recursive evaluation of ForwardRef in get_type_hints - #21553

bpo-41341: Recursive evaluation of ForwardRef in get_type_hints#21553
gvanrossum merged 2 commits into
python:masterfrom
wyfo:forwardref_recursive_evaluation

wyfo commented Jul 20, 2020 •
edited by bedevere-bot
Loading

Uh oh!

Uh oh!

This comment has been minimized.

gvanrossum left a comment

Uh oh!

gvanrossum Jul 21, 2020

Uh oh!

wyfo Jul 22, 2020

Uh oh!

gvanrossum Jul 22, 2020

Uh oh!

isidentical commented Jul 22, 2020

Uh oh!

bedevere-bot commented Jul 22, 2020

Uh oh!

gvanrossum commented Jul 22, 2020

Uh oh!

pablogsal commented Jul 22, 2020

Uh oh!

miss-islington commented Jul 26, 2020

Uh oh!

bedevere-bot commented Jul 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

                                        {'a': tuple[T]})
+                  def test_double_forward(self):
+                      def foo(a: 'List[\'int\']'):

bpo-41341: Recursive evaluation of ForwardRef in get_type_hints by wyfo · Pull Request #21553 · python/cpython · GitHub

Repository navigation

bpo-41341: Recursive evaluation of ForwardRef in get_type_hints - #21553

bpo-41341: Recursive evaluation of ForwardRef in get_type_hints#21553gvanrossum merged 2 commits intopython:masterpython/cpython:masterfrom wyfo:forwardref_recursive_evaluationwyfo/cpython:forwardref_recursive_evaluationCopy head branch name to clipboard

Conversation

wyfo commented Jul 20, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum Jul 21, 2020

Choose a reason for hiding this comment

Uh oh!

wyfo Jul 22, 2020

Choose a reason for hiding this comment

Uh oh!

gvanrossum Jul 22, 2020

Choose a reason for hiding this comment

Uh oh!

isidentical commented Jul 22, 2020

Uh oh!

bedevere-bot commented Jul 22, 2020

Uh oh!

gvanrossum commented Jul 22, 2020

Uh oh!

pablogsal commented Jul 22, 2020

Uh oh!

miss-islington commented Jul 26, 2020

Uh oh!

bedevere-bot commented Jul 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bpo-41341: Recursive evaluation of ForwardRef in get_type_hints#21553
gvanrossum merged 2 commits into
python:masterfrom
wyfo:forwardref_recursive_evaluation

wyfo commented Jul 20, 2020 •
edited by bedevere-bot
Loading