bpo-41306: Allow scale value to not be rounded by E-Paine · Pull Request #21715 · python/cpython · GitHub

This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the from, to and tickinterval arguments. This PR uses noconv if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed).

Going into more detail for those who want it, the Tk change was made in commit 591f68c and means that the arguments listed above are rounded relative to the value of from. However, when rounding the from argument (line 623), it is rounded relative to itself (i.e. rounding 0) and therefore the assigned value for from is always what is given (no matter what values of from and resolution).

https://bugs.python.org/issue41306

Automerge-Triggered-By: @pablogsal

I recently got an update on the Tk issue I created which, in short, says this change is not a bug and is here to stay (hence < is correct rather than !=). @serhiy-storchaka, would you mind please re-reviewing this PR (you may wish to credit yourself in the news as the code changes are pretty much just your's now :-).

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

@E-Paine: Status check is done, and it's a success ✅ .

Sorry, I can't merge this PR. Reason: 2 of 4 required status checks have not succeeded: 1 expected..

Probably dumb question: what's the status check (what is it checking for - is there something wrong with the PR)?

@E-Paine: Status check is done, and it's a success ✅ .

Thanks @E-Paine for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

Sorry @E-Paine, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker aecf036738a404371303e770f4ce4fd9f7d43de7 3.9

GH-22596 is a backport of this pull request to the 3.8 branch.

This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed). Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`). Automerge-Triggered-By: @pablogsal (cherry picked from commit aecf036) Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>

Am I able do the cherry pick because I don't have repo write permissions?

This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed). Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`). Automerge-Triggered-By: @pablogsal (cherry picked from commit aecf036) Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>

Thanks @E-Paine for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed). Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`). Automerge-Triggered-By: @pablogsal (cherry picked from commit aecf036) Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>

GH-22597 is a backport of this pull request to the 3.9 branch.

This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed). Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`). Automerge-Triggered-By: @pablogsal (cherry picked from commit aecf036) Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>

@pablogsal thanks!

* origin/master: (147 commits) Fix the attribute names in the docstring of GenericAlias (pythonGH-22594) bpo-39337: Add a test case for normalizing of codec names (pythonGH-19069) bpo-41557: Update Windows installer to use SQLite 3.33.0 (pythonGH-21960) bpo-41976: Fix the fallback to gcc of ctypes.util.find_library when using gcc>9 (pythonGH-22598) bpo-41306: Allow scale value to not be rounded (pythonGH-21715) bpo-41970: Avoid test failure in test_lib2to3 if the module is already imported (pythonGH-22595) bpo-41376: Fix the documentation of `site.getusersitepackages()` (pythonGH-21602) Revert "bpo-26680: Incorporate is_integer in all built-in and standard library numeric types (pythonGH-6121)" (pythonGH-22584) bpo-41923: PEP 613: Add TypeAlias to typing module (python#22532) Fix comment about PyObject_IsTrue. (pythonGH-22343) bpo-38605: Make 'from __future__ import annotations' the default (pythonGH-20434) bpo-41905: Add abc.update_abstractmethods() (pythonGH-22485) bpo-41944: No longer call eval() on content received via HTTP in the UnicodeNames tests (pythonGH-22575) bpo-41944: No longer call eval() on content received via HTTP in the CJK codec tests (pythonGH-22566) Post 3.10.0a1 Python 3.10.0a1 bpo-41584: clarify when the reflected method of a binary arithemtic operator is called (python#22505) bpo-41939: Fix test_site.test_license_exists_at_url() (python#22559) bpo-41774: Tweak new programming FAQ entry (pythonGH-22562) bpo-41936. Remove macros Py_ALLOW_RECURSION/Py_END_ALLOW_RECURSION (pythonGH-22552) ...

This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed). Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.c#L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`). Automerge-Triggered-By: @pablogsal

Thanks @E-Paine for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

GH-96484 is a backport of this pull request to the 3.7 branch.

This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed). Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`). Automerge-Triggered-By: @pablogsal (cherry picked from commit aecf036) Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>

Allow scale value to not be rounded

1c8759c

the-knights-who-say-ni added the CLA signed label Aug 3, 2020

bedevere-bot added the awaiting review label Aug 3, 2020

serhiy-storchaka reviewed Aug 3, 2020

View reviewed changes

Comment thread Lib/tkinter/test/test_tkinter/test_widgets.py Outdated

Reverted 'allow_not_rounded' changes and action Serhiy's recommendation

fc07de8

E-Paine force-pushed the test_from branch from c29f8f6 to fc07de8 Compare August 3, 2020 13:42

blurb-it Bot and others added 2 commits August 3, 2020 13:44

📜🤖 Added by blurb_it.

e184ad8

Put "conv" kwarg on new line

bdd3cb5

Merge 'master' into test_from

a8ac6bd

terryjreedy mentioned this pull request Sep 25, 2020

bpo-39107: Updated Tcl and Tk to 8.6.10 in Windows installer #22405

Merged

terryjreedy reviewed Sep 25, 2020

View reviewed changes

Comment thread Lib/tkinter/test/test_tkinter/test_widgets.py Outdated

Use @terryjreedy 's conv kwarg suggestion

8b8060e

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

pablogsal self-assigned this Oct 8, 2020

pablogsal reviewed Oct 8, 2020

View reviewed changes

Comment thread Misc/NEWS.d/next/Tests/2020-08-03-13-44-37.bpo-41306.VDoWXI.rst Outdated

Update Misc/NEWS.d/next/Tests/2020-08-03-13-44-37.bpo-41306.VDoWXI.rst

3f9147a

pablogsal approved these changes Oct 8, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Oct 8, 2020

pablogsal added needs backport to 3.8 labels Oct 8, 2020

pablogsal reviewed Oct 8, 2020

View reviewed changes

Comment thread Lib/tkinter/test/test_tkinter/test_widgets.py Outdated

pablogsal reviewed Oct 8, 2020

View reviewed changes

Comment thread Lib/tkinter/test/test_tkinter/test_widgets.py Outdated

Update Lib/tkinter/test/test_tkinter/test_widgets.py

42ec16e

pablogsal reviewed Oct 8, 2020

View reviewed changes

Comment thread Lib/tkinter/test/test_tkinter/test_widgets.py Outdated

miss-islington merged commit aecf036 into python:master Oct 8, 2020

bedevere-bot removed the awaiting merge label Oct 8, 2020

miss-islington assigned miss-islington and unassigned pablogsal Oct 8, 2020

bedevere-bot removed the needs backport to 3.8 label Oct 8, 2020

pablogsal removed the needs backport to 3.9 label Oct 8, 2020

pablogsal added the needs backport to 3.9 label Oct 8, 2020

bedevere-bot removed the needs backport to 3.9 label Oct 8, 2020

E-Paine deleted the test_from branch October 8, 2020 16:20

gpshead added the needs backport to 3.7 label Sep 1, 2022

bedevere-bot removed the needs backport to 3.7 label Sep 1, 2022

bpo-41306: Allow scale value to not be rounded by E-Paine · Pull Request #21715 · python/cpython · GitHub

Uh oh!

Uh oh!

bpo-41306: Allow scale value to not be rounded - #21715

bpo-41306: Allow scale value to not be rounded#21715miss-islington merged 9 commits intopython:masterpython/cpython:masterfrom E-Paine:test_fromE-Paine/cpython:test_fromCopy head branch name to clipboard

Conversation

E-Paine commented Aug 3, 2020 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

E-Paine commented Aug 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington commented Oct 8, 2020

Uh oh!

miss-islington commented Oct 8, 2020

Uh oh!

miss-islington commented Oct 8, 2020

Uh oh!

miss-islington commented Oct 8, 2020

Uh oh!

Uh oh!

E-Paine commented Oct 8, 2020

Uh oh!

miss-islington commented Oct 8, 2020

Uh oh!

miss-islington commented Oct 8, 2020

Uh oh!

miss-islington commented Oct 8, 2020

Uh oh!

bedevere-bot commented Oct 8, 2020

Uh oh!

E-Paine commented Oct 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Oct 8, 2020

Uh oh!

bedevere-bot commented Oct 8, 2020

Uh oh!

E-Paine commented Oct 8, 2020

Uh oh!

miss-islington commented Sep 1, 2022

Uh oh!

bedevere-bot commented Sep 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bpo-41306: Allow scale value to not be rounded#21715
miss-islington merged 9 commits into
python:masterfrom
E-Paine:test_from

E-Paine commented Aug 3, 2020 •
edited by miss-islington
Loading

E-Paine commented Aug 16, 2020 •
edited
Loading

E-Paine commented Oct 8, 2020 •
edited
Loading