bpo-1635741 port zlib module to multi-phase init - #21995
Merged
vstinner merged 5 commits intoSep 7, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I don't get the CI failure - I ran clinic on zlibmodule and it didn't show any differences. Do I have to change the line endings or something like that? |
Sorry, something went wrong.
koubaa
force-pushed
the
bpo-1635741-zlib
branch
from
ae7d4e8 to
90864c9
Compare
September 2, 2020 02:08
koubaa
force-pushed
the
bpo-1635741-zlib
branch
from
90864c9 to
4a7e59a
Compare
September 2, 2020 23:17
Copy link
Copy Markdown
Contributor
Author
|
@shihai1991 @vstinner please review |
Sorry, something went wrong.
vstinner
reviewed
Sep 3, 2020
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The overall change looks correct, but I have a few comments.
Sorry, something went wrong.
Comment thread
Misc/NEWS.d/next/Core and Builtins/2020-08-28-20-54-04.bpo-1635741.7ijlcI.rst
Outdated
Comment thread
Modules/zlibmodule.c
Outdated
Comment thread
Modules/zlibmodule.c
Comment thread
Modules/zlibmodule.c
Outdated
Comment thread
Modules/zlibmodule.c
Outdated
Comment thread
Modules/zlibmodule.c
Outdated
Comment thread
Modules/zlibmodule.c
Outdated
vstinner
reviewed
Sep 4, 2020
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the update! The updated PR is way better, especially with defining_class. New review, likely the last one.
Sorry, something went wrong.
Comment thread
Modules/zlibmodule.c
Outdated
Comment thread
Modules/zlibmodule.c
Comment thread
Modules/zlibmodule.c
Outdated
Comment thread
Modules/zlibmodule.c
Outdated
Comment thread
Modules/zlibmodule.c
Outdated
shihai1991
reviewed
Sep 5, 2020
Comment thread
Modules/zlibmodule.c
Outdated
vstinner
reviewed
Sep 6, 2020
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Sep 10, 2020
* origin/master: (1373 commits) bpo-1635741: Port mashal module to multi-phase init (python#22149) bpo-1635741: Port _string module to multi-phase init (pythonGH-22148) bpo-1635741: Convert _sha256 types to heap types (pythonGH-22134) bpo-1635741: Port the termios to multi-phase init (PEP 489) (pythonGH-22139) bpo-41732: add iterator to memoryview (pythonGH-22119) bpo-40744: Drop support for SQLite pre 3.7.3 (pythonGH-20909) bpo-41316: Make tarfile follow specs for FNAME (pythonGH-21511) bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (pythonGH-22092) bpo-1635741 port _curses_panel to multi-phase init (PEP 489) (pythonGH-21986) bpo-1635741: Port _overlapped module to multi-phase init (pythonGH-22051) bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (pythonGH-22050) bpo-1635741 port zlib module to multi-phase init (pythonGH-21995) [doc] Add link to Generic in typing (pythonGH-22125) bpo-41513: Expand comments and add references for a better understanding (pythonGH-22123) bpo-1635741: Port _sha1, _sha512, _md5 to multiphase init (pythonGH-21818) closes bpo-41723: Fix an error in the py_compile documentation. (pythonGH-22110) [doc] Fix padding in some typing definitions (pythonGH-22114) Fix documented Python version for venv --upgrade-deps (pythonGH-22113) bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581) bpo-41687: Fix sendfile implementation to work with Solaris (python#22040) ...
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Port the zlib extension module to multi-phase initialization (PEP 489).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue1635741