FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser by pablogsal · Pull Request #22077 · python/cpython · GitHub

Repository navigation

bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser - #22077

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-41697
Sep 3, 2020
Merged

pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-41697

Conversation

pablogsal commented Sep 3, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Building with clang 11 and ./configure --with-pydebug --with-address-sanitizer shows no more problems for me

https://bugs.python.org/issue41697

pablogsal requested a review from gvanrossum September 3, 2020 10:49
pablogsal force-pushed the bpo-41697 branch 2 times, most recently from 8b8b737 to a9fb29d Compare September 3, 2020 11:01
pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 3, 2020
bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 3, 2020
pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 3, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a9fb29dbdb622487ebc7387e4b3778e157946540 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 3, 2020
python deleted a comment from bedevere-bot Sep 3, 2020

Copy link
Copy Markdown
Member Author

ASAN build of this PR: https://buildbot.python.org/all/#/builders/584/builds/1

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good solution!

pablogsal merged commit 315a61f into python:master Sep 3, 2020

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

pablogsal deleted the bpo-41697 branch September 3, 2020 14:29

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 315a61f7a9418d904e0eea14b1f054fac3a90e9f 3.9

pablogsal added a commit to pablogsal/cpython that referenced this pull request Sep 3, 2020
…ents in the parser (pythonGH-22077).

(cherry picked from commit 315a61f)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Copy link
Copy Markdown

GH-22079 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit that referenced this pull request Sep 3, 2020
…ents in the parser (GH-22077) (GH-22079)

(cherry picked from commit 315a61f)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 5, 2020
…lots1

* origin/master: (63 commits)
  bpo-41627: Distinguish 32 and 64-bit user site packages on Windows (pythonGH-22098)
  bpo-38585: Remove references to defusedexpat (pythonGH-22095)
  bpo-41721: Add xlc options (pythonGH-22096)
  bpo-40486: Specify what happens if directory content change diring iteration (pythonGH-22025)
  bpo-41638: Improve ProgrammingError message for absent parameter. (pythonGH-21999)
  bpo-41713: _signal doesn't use multi-phase init (pythonGH-22087)
  bpo-41700: Skip test if the locale is not supported (pythonGH-22081)
  [doc] Update documentation on logging optimization. (pythonGH-22075)
  Fix 'gather' rules in the python parser generator (pythonGH-22021)
  bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser (pythonGH-22077)
  [doc] Fix a typo in the graphlib docs (python#22030)
  bpo-1635741: Port _signal module to multi-phase init (PEP 489) (pythonGH-22049)
  bpo-39883: Use BSD0 license for code in docs (pythonGH-17635)
  bpo-39010: Improve test shutdown (python#22066)
  bpo-41696: Fix handling of debug mode in asyncio.run (python#22069)
  bpo-41690: Use a loop to collect args in the parser instead of recursion (pythonGH-22053)
  closes bpo-41689: Preserve text signature from tp_doc in C heap type creation. (pythonGH-22058)
  Fix invalid escape sequences in the peg_highlight Sphinx extension (pythonGH-22047)
  bpo-41675: Modernize siginterrupt calls (pythonGH-22028)
  bpo-41685: Don't pin setuptools version anymore in Doc/Makefile (pythonGH-22062)
  ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL