FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41687: Fix error handling in Solaris sendfile implementation by kulikjak · Pull Request #22128 · python/cpython · GitHub

/ cpython Public

bpo-41687: Fix error handling in Solaris sendfile implementation - #22128

Merged
miss-islington merged 1 commit into
python:masterfrom
kulikjak:fix-Solaris-sendfile-followup
Sep 9, 2020
ConversationCommits (1)ChecksFiles changed
Merged

bpo-41687: Fix error handling in Solaris sendfile implementation#22128
miss-islington merged 1 commit into
python:masterfrom
kulikjak:fix-Solaris-sendfile-followup

Conversation

kulikjak commented Sep 7, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

I just realized that my recent PR with sendfile on Solaris (PR 22040) has broken error handling.

Sorry for that, this simple followup fixes that.

https://bugs.python.org/issue41687

Automerge-Triggered-By: @1st1

kulikjak mentioned this pull request Sep 7, 2020
Merged

1st1 commented Sep 8, 2020

Copy link
Copy Markdown
Member

I just realized that my recent PR with sendfile on Solaris (PR 22040) has broken error handling.

How is it broken?

kulikjak commented Sep 9, 2020

Copy link
Copy Markdown
Contributor Author

I used new variable res for fstat and the enclosing while loop, but not for the error checking block right below that (it checks ret rather than res).

if (ret < 0)
    return (!async_err) ? posix_error() : NULL;

1st1 commented Sep 9, 2020

Copy link
Copy Markdown
Member

Got it!

1st1 closed this Sep 9, 2020
1st1 reopened this Sep 9, 2020

miss-islington commented Sep 9, 2020

Copy link
Copy Markdown
Contributor

@kulikjak: Status check is done, and it's a success ✅ .

miss-islington merged commit fa8c9e7 into python:master Sep 9, 2020

miss-islington commented Sep 16, 2020

Copy link
Copy Markdown
Contributor

Thanks @kulikjak for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

bedevere-bot commented Sep 16, 2020

Copy link
Copy Markdown

GH-22274 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2020
bpo-41687: Fix error handling in Solaris sendfile implementation (pyt…
94c0e73 
…honGH-22128)

I just realized that my recent PR with sendfile on Solaris ([PR 22040](python#22040)) has broken error handling.

Sorry for that, this simple followup fixes that.

Automerge-Triggered-By: @1st1
(cherry picked from commit fa8c9e7)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
miss-islington added a commit that referenced this pull request Sep 16, 2020
bpo-41687: Fix error handling in Solaris sendfile implementation (GH-…
6a39888 
…22128)

I just realized that my recent PR with sendfile on Solaris ([PR 22040](#22040)) has broken error handling.

Sorry for that, this simple followup fixes that.

Automerge-Triggered-By: @1st1
(cherry picked from commit fa8c9e7)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-41687: Fix error handling in Solaris sendfile implementation (pyt…
bcbd616 
…honGH-22128)

I just realized that my recent PR with sendfile on Solaris ([PR 22040](python#22040)) has broken error handling.

Sorry for that, this simple followup fixes that.

Automerge-Triggered-By: @1st1
kulikjak mentioned this pull request Dec 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 1st1 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL