bpo-35293: Remove RemovedInSphinx40Warning - #22198
Merged
corona10 merged 3 commits intoSep 18, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The current failure is not related to this PR /Users/corona10/oss/cpython/Doc/library/string.rst:311:duplicate token description of sign, other instance in library/functions |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
I don't understand. All jobs are now green. Did you re-run some jobs? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
I expected that Travis CI - Pull Request will failed but not on this PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I fixed https://bugs.python.org/issue41762 with commit 8af239e, PR #22281. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Nice!, I rebased it! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I confirm that the PR fix RemovedInSphinx40Warning warnings. Without the PR: $ cd Doc $ make clean $ make venv PYTHON=../python && make html SPHINXOPTS="-j10" (...) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:310: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyCoroutineMethod'> return PyClassmember.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:304: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyCoroutineFunction'> return PyModulelevel.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'> return PyModulelevel.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:316: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyAwaitableFunction'> return PyClassmember.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'> return PyModulelevel.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'> return PyModulelevel.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:310: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyCoroutineMethod'> return PyClassmember.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'> return PyModulelevel.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:322: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyAwaitableMethod'> return PyClassmember.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'> return PyModulelevel.run(self) With the PR, I don't see these warnings anymore: $ cd Doc $ make clean $ make venv PYTHON=../python && make html SPHINXOPTS="-j10" (...) |
Sorry, something went wrong.
vstinner
reviewed
Sep 18, 2020
Comment thread
Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst
Outdated
Comment thread
Doc/tools/extensions/pyspecific.py
…cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
approved these changes
Sep 18, 2020
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 18, 2020
* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Copy link
Copy Markdown
|
GH-22302 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 18, 2020
* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Copy link
Copy Markdown
|
GH-22303 is a backport of this pull request to the 3.8 branch. |
Sorry, something went wrong.
miss-islington
added a commit
that referenced
this pull request
Sep 18, 2020
* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 18, 2020
* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35293