bpo-1635741 port _lsprof to multi-phase init (PEP 489) - #22220
Conversation
Sorry, something went wrong.
|
@vstinner @corona10 @shihai1991 please review |
Sorry, something went wrong.
|
compile warning: ‘getstats_doc’ defined but not used [-Wunused-const-variable= |
Sorry, something went wrong.
Oops, I meant to remove that! |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM, but I have some coding style requests.
Sorry, something went wrong.
| static PyStructSequence_Desc profiler_entry_desc = { | ||
| "_lsprof.profiler_entry", /* name */ | ||
| NULL, /* doc */ | ||
| "", /* doc */ |
There was a problem hiding this comment.
IMO PyType_FromSpec() should accept tp_doc=NULL, I created: https://bugs.python.org/issue41832
I don't ask you to change your PR, "" vs NULL can be changed again later.
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM. Thanks, the new code is easier to read!
Sorry, something went wrong.
| .name = "_lsprof.profiler_entry", | ||
| .doc = "", | ||
| .fields = profiler_entry_fields, | ||
| .n_in_sequence = 6 |
There was a problem hiding this comment.
For me, it's way easier to read than the old format, thanks!
Sorry, something went wrong.
| if (PyModule_AddType(module, state->stats_subentry_type) < 0) { | ||
| return -1; | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks, the new code is more regular (create type, add type, create type, add type, ...) and so easier to read!
Sorry, something went wrong.
* origin/master: (27 commits) bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388) bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387) bpo-41833: threading.Thread now uses the target name (pythonGH-22357) bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633) bpo-33822: Update IDLE section of What's New 3.8 (pythonGH-22383) bpo-41844: Add IDLE section to What's New 3.9 (GN-22382) bpo-41841: Prepare IDLE News for 3.10 (pythonGH-22379) bpo-37779 : Add information about the overriding behavior of ConfigParser.read (pythonGH-15177) bpo-40170: Use inline _PyType_HasFeature() function (pythonGH-22375) bpo-40941: Fix stackdepth compiler warnings (pythonGH-22377) bpo-40941: Fix fold_tuple_on_constants() compiler warnings (pythonGH-22378) bpo-40521: Fix PyUnicode_InternInPlace() (pythonGH-22376) bpo-41834: Remove _Py_CheckRecursionLimit variable (pythonGH-22359) bpo-1635741, unicodedata: add ucd_type parameter to UCD_Check() macro (pythonGH-22328) bpo-1635741: Port _lsprof extension to multi-phase init (PEP 489) (pythonGH-22220) bpo-41513: Improve order of adding fractional values. Improve variable names. (pythonGH-22368) bpo-41816: `StrEnum.__str__` is `str.__str__` (pythonGH-22362) bpo-35764: Rewrite the IDLE Calltips doc section (pythonGH-22363) bpo-41810: Reintroduce `types.EllipsisType`, `.NoneType` & `.NotImplementedType` (pythonGH-22336) bpo-41602: raise SIGINT exit code on KeyboardInterrupt from pymain_run_module (python#21956) ...
https://bugs.python.org/issue1635741