FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41802: Document 'PyDict_DelItem' can raise a 'KeyError' by ideasman42 · Pull Request #22291 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-41802: Document 'PyDict_DelItem' can raise a 'KeyError' - #22291

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
ideasman42:patch-1
Oct 2, 2020
ConversationCommits (3)ChecksFiles changed
Merged

bpo-41802: Document 'PyDict_DelItem' can raise a 'KeyError'#22291
serhiy-storchaka merged 3 commits into
python:masterfrom
ideasman42:patch-1

Conversation

ideasman42 commented Sep 17, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Correct Documentation, as it's not documented that deleting a key PyDict_DelItem will raise a KeyError if it's not in the dictionary.

This caused me to accidentally misuse the API recently.

https://developer.blender.org/rBef4877fde311f0638617cc6ff29cf64aedb4dab3

issue #41802

https://bugs.python.org/issue41802

the-knights-who-say-ni commented Sep 17, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@ideasman42

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 17, 2020
iritkatriel reviewed Sep 18, 2020
View reviewed changes
Comment thread Doc/c-api/dict.rst

ideasman42 commented Sep 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Signed the CLA (not sure how long these systems take to refresh).

iritkatriel reviewed Sep 25, 2020
View reviewed changes
Comment thread Doc/c-api/dict.rst Outdated
Update dict.rst
1747c17 
Use new sentence based on feedback.

iritkatriel commented Oct 2, 2020

Copy link
Copy Markdown
Member

You need to link this PR to the bpo ticket: https://bugs.python.org/issue41802
Put the ticket number in the title of the PR (look at other PRs for examples).

serhiy-storchaka changed the title Document 'PyDict_DelItem' can raise a 'KeyError' bpo-41802: Document 'PyDict_DelItem' can raise a 'KeyError' Oct 2, 2020
serhiy-storchaka merged commit 20ce62f into python:master Oct 2, 2020

miss-islington commented Oct 2, 2020

Copy link
Copy Markdown
Contributor

Thanks @ideasman42 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2020
bpo-41802: Document 'PyDict_DelItem' can raise a 'KeyError' (pythonGH…
0e0871b 
…-22291)

(cherry picked from commit 20ce62f)

Co-authored-by: Campbell Barton <ideasman42@gmail.com>

bedevere-bot commented Oct 2, 2020

Copy link
Copy Markdown

GH-22493 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2020
bpo-41802: Document 'PyDict_DelItem' can raise a 'KeyError' (pythonGH…
9585d39 
…-22291)

(cherry picked from commit 20ce62f)

Co-authored-by: Campbell Barton <ideasman42@gmail.com>

bedevere-bot commented Oct 2, 2020

Copy link
Copy Markdown

GH-22494 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 2, 2020
bpo-41802: Document 'PyDict_DelItem' can raise a 'KeyError' (GH-22291)
ab32ea8 
(cherry picked from commit 20ce62f)

Co-authored-by: Campbell Barton <ideasman42@gmail.com>
miss-islington added a commit that referenced this pull request Oct 2, 2020
bpo-41802: Document 'PyDict_DelItem' can raise a 'KeyError' (GH-22291)
6dc8e0e 
(cherry picked from commit 20ce62f)

Co-authored-by: Campbell Barton <ideasman42@gmail.com>
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
bpo-41802: Document 'PyDict_DelItem' can raise a 'KeyError' (pythonGH…
95de362 
…-22291)

(cherry picked from commit 20ce62f)

Co-authored-by: Campbell Barton <ideasman42@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-41802: Document 'PyDict_DelItem' can raise a 'KeyError' (pythonGH…
4515dd3 
…-22291)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes
serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL