FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41840: Report module-level globals as both local and global in the symtable module by pablogsal · Pull Request #22391 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-41840: Report module-level globals as both local and global in the symtable module - #22391

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-41840
Oct 3, 2020
ConversationCommits (1)ChecksFiles changed
Merged

bpo-41840: Report module-level globals as both local and global in the symtable module#22391
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-41840

Conversation

pablogsal commented Sep 23, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal changed the title Report module-level globals as both local and global in the symtable module bpo-41840: Report module-level globals as both local and global in the symtable module Sep 23, 2020
pablogsal force-pushed the bpo-41840 branch 2 times, most recently from dfca0a8 to dc8fb13 Compare September 23, 2020 22:22
ZackerySpytz reviewed Oct 2, 2020
View reviewed changes
Comment thread Lib/symtable.py Outdated
Comment thread Lib/symtable.py Outdated
pablogsal merged commit fb0a465 into python:master Oct 3, 2020

miss-islington commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

pablogsal deleted the bpo-41840 branch October 3, 2020 19:46

miss-islington commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fb0a4651f1be4ad936f8277478f73f262d8eeb72 3.9

miss-islington commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

Sorry @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker fb0a4651f1be4ad936f8277478f73f262d8eeb72 3.8

pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 3, 2020
[3.9] bpo-41840: Report module-level globals as both local and global…
ae1a2af 
… in the symtable module (pythonGH-22391).

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

bedevere-bot commented Oct 3, 2020

Copy link
Copy Markdown

GH-22528 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 3, 2020
[3.8] bpo-41840: Report module-level globals as both local and global…
4a7f1f8 
… in the symtable module (pythonGH-22391).

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Oct 3, 2020
[3.9] bpo-41840: Report module-level globals as both local and global…
7b7aa94 
… in the symtable module (GH-22391). (GH-22528)

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Oct 3, 2020
[3.8] bpo-41840: Report module-level globals as both local and global…
fd22823 
… in the symtable module (GH-22391). (GH-22529)

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-41840: Report module-level globals as both local and global in th…
1119448 
…e symtable module (pythonGH-22391)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
ZackerySpytz ZackerySpytz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL