FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41867: Include options for timespec in docstrings of isoformat methods by cool-RR · Pull Request #22418 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-41867: Include options for timespec in docstrings of isoformat methods - #22418

Merged
taleinat merged 3 commits into
python:masterfrom
cool-RR:2020-09-26-isoformat
Oct 3, 2020
ConversationCommits (3)ChecksFiles changed
Merged

bpo-41867: Include options for timespec in docstrings of isoformat methods#22418
taleinat merged 3 commits into
python:masterfrom
cool-RR:2020-09-26-isoformat

Conversation

cool-RR commented Sep 26, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

taleinat commented Oct 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi Ram, thanks for this, it's a nice addition!

What about the doc-strings for the C implementation? (e.g. here)

taleinat added skip news docs Documentation in the Doc dir labels Oct 2, 2020

taleinat commented Oct 2, 2020

Copy link
Copy Markdown
Contributor

What about the doc-strings for the C implementation? (e.g. here)

It seems that the C implementation for datetime.iso_format() already has something very similar in its doc-string, while time.iso_format() doesn't.

Let's make these all consistent.

cool-RR force-pushed the 2020-09-26-isoformat branch 2 times, most recently from e2e0ba5 to 8a7abe4 Compare October 3, 2020 09:34

cool-RR commented Oct 3, 2020

Copy link
Copy Markdown
Contributor Author

Done.

taleinat suggested changes Oct 3, 2020
View reviewed changes

taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Almost good to go, just a couple of small comments.

Comment thread Misc/NEWS.d/next/Library/2020-09-26-19-45-06.bpo-41867.hcueGL.rst Outdated
Comment thread Lib/datetime.py Outdated

bedevere-bot commented Oct 3, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

cool-RR force-pushed the 2020-09-26-isoformat branch from 8a7abe4 to 70dd716 Compare October 3, 2020 09:46

cool-RR commented Oct 3, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Oct 3, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

bedevere-bot requested a review from taleinat October 3, 2020 09:46
taleinat suggested changes Oct 3, 2020
View reviewed changes

taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wow, @cool-RR, that was quick!

One more thing...

Comment thread Modules/_datetimemodule.c Outdated

bedevere-bot commented Oct 3, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

cool-RR force-pushed the 2020-09-26-isoformat branch from 70dd716 to dbfeb83 Compare October 3, 2020 09:53

cool-RR commented Oct 3, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Oct 3, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

cool-RR force-pushed the 2020-09-26-isoformat branch from dbfeb83 to 2cf017b Compare October 3, 2020 09:58

cool-RR commented Oct 3, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Oct 3, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

bedevere-bot requested a review from taleinat October 3, 2020 09:59
taleinat approved these changes Oct 3, 2020
View reviewed changes

taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

taleinat merged commit 5230131 into python:master Oct 3, 2020

miss-islington commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

Thanks @cool-RR for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020
bpo-41867: List options for timespec in docstrings of isoformat metho…
ff70df1 
…ds (pythonGH-22418)

(cherry picked from commit 5230131)

Co-authored-by: Ram Rachum <ram@rachum.com>

bedevere-bot commented Oct 3, 2020

Copy link
Copy Markdown

GH-22518 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020
bpo-41867: List options for timespec in docstrings of isoformat metho…
84ca5e5 
…ds (pythonGH-22418)

(cherry picked from commit 5230131)

Co-authored-by: Ram Rachum <ram@rachum.com>

bedevere-bot commented Oct 3, 2020

Copy link
Copy Markdown

GH-22519 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 3, 2020
bpo-41867: List options for timespec in docstrings of isoformat metho…
9aa34f1 
…ds (GH-22418)

(cherry picked from commit 5230131)

Co-authored-by: Ram Rachum <ram@rachum.com>
taleinat pushed a commit that referenced this pull request Oct 3, 2020
[3.9] bpo-41867: List options for timespec in docstrings of isoformat…
8ca0831 
… methods (GH-22418)

(cherry picked from commit 5230131)

Co-authored-by: Ram Rachum <ram@rachum.com>
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
[3.9] bpo-41867: List options for timespec in docstrings of isoformat…
faaa303 
… methods (pythonGH-22418)

(cherry picked from commit 5230131)

Co-authored-by: Ram Rachum <ram@rachum.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-41867: List options for timespec in docstrings of isoformat metho…
b85c4f4 
…ds (pythonGH-22418)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

abalkin Awaiting requested review from abalkin
pganssle Awaiting requested review from pganssle
1 more reviewer
taleinat taleinat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL