FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41919: Move the codecs.register operation to the setup of testcases. by shihai1991 · Pull Request #22513 · python/cpython · GitHub

/ cpython Public

bpo-41919: Move the codecs.register operation to the setup of testcases. - #22513

Merged
vstinner merged 2 commits into
python:masterfrom
shihai1991:update_test_codecs
Oct 16, 2020
ConversationCommits (2)ChecksFiles changed
Merged

bpo-41919: Move the codecs.register operation to the setup of testcases.#22513
vstinner merged 2 commits into
python:masterfrom
shihai1991:update_test_codecs

Conversation

shihai1991 commented Oct 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
  • Move the codecs.register operation to the setup of testcases.
  • Remove _codecs._forget_codecs and _PyCodec_Forget().

https://bugs.python.org/issue41919

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Oct 3, 2020

shihai1991 commented Oct 3, 2020

Copy link
Copy Markdown
Member Author

Hi, victor. Pls take a look when you have free time. @vstinner

vstinner reviewed Oct 3, 2020
View reviewed changes
Comment thread Lib/test/test_codecs.py
Comment thread Lib/test/test_codecs.py Outdated
shihai1991 changed the title bpo-41919: Move the codecs.register operation to testcases. bpo-41919: Move the codecs.register operation to the inside of testcases. Oct 8, 2020
shihai1991 changed the title bpo-41919: Move the codecs.register operation to the inside of testcases. bpo-41919: Move the codecs.register operation to the setup of testcases. Oct 8, 2020
vstinner approved these changes Oct 8, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

I checked for leaks: ./python -m test test_codecs -R 3:3 pass (no leak), good!

vstinner mentioned this pull request Oct 8, 2020
Closed
shihai1991 closed this Oct 15, 2020
shihai1991 reopened this Oct 15, 2020

vstinner commented Oct 15, 2020

Copy link
Copy Markdown
Member

It seems like your PR is sick: it got two Travis CI, and one will never complete. It's a victim of python/core-workflow#377 bug.

Can you try to recreate a new PR? For example, rename your local branch update_test_codecs to update_test_codecs2 and publish it.

Or wait until python/core-workflow#377 is fixed (Travis CI made optional).

shihai1991 commented Oct 15, 2020

Copy link
Copy Markdown
Member Author

It seems like your PR is sick: it got two Travis CI, and one will never complete. It's a victim of python/core-workflow#377 bug.

Can you try to recreate a new PR? For example, rename your local branch update_test_codecs to update_test_codecs2 and publish it.

Or wait until python/core-workflow#377 is fixed (Travis CI made optional).

Copy that, I can waiting the fix of issues/377 :)

vstinner merged commit c9f696c into python:master Oct 16, 2020

vstinner commented Oct 16, 2020

Copy link
Copy Markdown
Member

Copy that, I can waiting the fix of issues/377 :)

Travis CI is no longer mandatory.

I merged your PR, thanks.

shihai1991 commented Oct 16, 2020

Copy link
Copy Markdown
Member Author

Copy that, I can waiting the fix of issues/377 :)

Travis CI is no longer mandatory.

I merged your PR, thanks.

Wow, thanks, victor.

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-41919, test_codecs: Move codecs.register calls to setUp() (python…
9011f3f 
…GH-22513)

* Move the codecs' (un)register operation to testcases.
* Remove _codecs._forget_codec() and _PyCodec_Forget()
pablogsal added a commit that referenced this pull request Oct 25, 2020
Revert "bpo-41919, test_codecs: Move codecs.register calls to setUp() (…
b1c9a20 
…GH-22513)"

This reverts commit c9f696c.
pablogsal mentioned this pull request Oct 25, 2020
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-41919, test_codecs: Move codecs.register calls to setUp() (python…
e00b598 
…GH-22513)

* Move the codecs' (un)register operation to testcases.
* Remove _codecs._forget_codec() and _PyCodec_Forget()
shihai1991 mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL