| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 25ba819 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
@ericsnowcurrently, please take a look. It has relation to the code added by you (support of arbitrary mapping as sys.modules). |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
There was a problem hiding this comment.
I went through the changes and they look OK to me!
To review, I needed to merge current master & resolve a small conflict; I hope you don't mind me pushing that into this PR.
@ericsnowcurrently, do you want to review as well? I might have missed some big-picture issue.
Sorry, something went wrong.
|
Thank you @encukou. I planned to merge with master, but it needed some time because there is easy to miss some detail in large image when change how reference counted. Good opportunity to do one more review. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 03e405f 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
Unfortunately that last merge was with a leaking master, which is now fixed. Another merge should fix the tests. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit c31124f 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
And now the tests failed because of bpo-42794. This PR seems cursed :( |
Sorry, something went wrong.
|
Thanks @serhiy-storchaka for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry, something went wrong.
|
Sorry, @serhiy-storchaka and @encukou, I could not cleanly backport this to 3.9 due to a conflict. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
https://bugs.python.org/issue41994