FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41994: Fix refcount issues in Python/import.c by serhiy-storchaka · Pull Request #22632 · python/cpython · GitHub

/ cpython Public

bpo-41994: Fix refcount issues in Python/import.c - #22632

Merged
encukou merged 10 commits into
python:masterfrom
serhiy-storchaka:import-refcounts
Jan 12, 2021
Merged

bpo-41994: Fix refcount issues in Python/import.c#22632
encukou merged 10 commits into
python:masterfrom
serhiy-storchaka:import-refcounts

Conversation

serhiy-storchaka commented Oct 10, 2020
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Comment thread Python/import.c Outdated
Comment thread Python/import.c Outdated
Comment thread Python/import.c Outdated
pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 11, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 25ba819 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 11, 2020

Copy link
Copy Markdown
Member Author

@ericsnowcurrently, please take a look. It has relation to the code added by you (support of arbitrary mapping as sys.modules).

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 17, 2020

encukou left a comment
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I went through the changes and they look OK to me!
To review, I needed to merge current master & resolve a small conflict; I hope you don't mind me pushing that into this PR.

@ericsnowcurrently, do you want to review as well? I might have missed some big-picture issue.

Copy link
Copy Markdown
Member Author

Thank you @encukou. I planned to merge with master, but it needed some time because there is easy to miss some detail in large image when change how reference counted. Good opportunity to do one more review.

serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 29, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 03e405f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 29, 2020
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 30, 2020

encukou commented Dec 30, 2020

Copy link
Copy Markdown
Member

Unfortunately that last merge was with a leaking master, which is now fixed. Another merge should fix the tests.

serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 30, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit c31124f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 30, 2020

encukou commented Jan 5, 2021
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

And now the tests failed because of bpo-42794. This PR seems cursed :(

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit bc4ba0c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 5, 2021
bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 5, 2021
encukou merged commit 4db8988 into python:master Jan 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka and @encukou, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4db8988420e0a122d617df741381b0c385af032c 3.9

ZeroIntensity removed type-bug An unexpected behavior, bug, or error needs backport to 3.9 labels Feb 17, 2025
serhiy-storchaka deleted the import-refcounts branch July 1, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL