FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-38250: minor Flag refactor by belm0 · Pull Request #22734 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-38250: minor Flag refactor - #22734

Closed
belm0 wants to merge 2 commits into
python:masterfrom
belm0:flag_small_refactor
ConversationCommits (2)ChecksFiles changed
Closed

bpo-38250: minor Flag refactor#22734
belm0 wants to merge 2 commits into
python:masterfrom
belm0:flag_small_refactor

Conversation

belm0 commented Oct 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Extracted some minor refactoring from a larger work in progress:

  • clarify used return values of _decompose() calls
  • __invert__(): use in-place OR operator, remove unneeded cast

skip news

https://bugs.python.org/issue38250

belm0 requested a review from ethanfurman as a code owner October 17, 2020 01:52
auvipy suggested changes Oct 17, 2020
View reviewed changes

auvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

dont this need some test adjustment?

belm0 commented Oct 17, 2020

Copy link
Copy Markdown
Contributor Author

dont this need some test adjustment?

no, since there is no change in functionality

belm0 force-pushed the flag_small_refactor branch from d1a0c1c to b86aa8e Compare November 23, 2020 00:36

github-actions Bot commented Dec 24, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 24, 2020

ethanfurman commented Jan 14, 2021

Copy link
Copy Markdown
Member

@belm0 this PR is no longer valid as Flag has been redesigned (using much, if not all, of your input). I would appreciate your feedback on GH-24215.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ethanfurman Awaiting requested review from ethanfurman
1 more reviewer
auvipy auvipy requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL