bpo-1635741: Port _csv to multi-phase init - #22838
Closed
encukou wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Uses code from: python#16078 Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com> Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com> Co-authored-by: Hai Shi <shihai1992@gmail.com>
This was referenced Oct 20, 2020
koubaa
reviewed
Oct 21, 2020
Comment thread
Objects/typeobject.c
| assert(PyType_Check(type)); | ||
| assert(type->tp_mro); | ||
| int i; | ||
| for (i = 0; i < PyTuple_GET_SIZE(type->tp_mro); i++) { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think it's better to call PyTuple_GET_SIZE before the for loop to only call it once.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
It's a macro for direct field access, so it doesn't really matter.
Sorry, something went wrong.
encukou
marked this pull request as ready for review
November 10, 2020 13:51
encukou
requested review from
1st1,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
ericsnowcurrently,
ericvsmith,
ethanfurman,
ezio-melotti,
gpshead,
gvanrossum,
ilevkivskyi,
lysnikolaou,
methane,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
terryjreedy and
tiran
as code owners
November 10, 2020 13:53
Copy link
Copy Markdown
Member
Author
|
Apologies for the mass review requests. I'll open a new PR. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #22835 and shows how the new _PyType_GetModuleByDef can be used. I would love these to go in as two separate commits.
https://bugs.python.org/issue1635741