Repository navigation
bpo-26131: deprecate the use of load_module() - #22905
Closed
brettcannon wants to merge 4 commits into
Closed
brettcannon wants to merge 4 commits into
brettcannon wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
warsaw
requested changes
Oct 23, 2020
warsaw
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
One suggestion. There are also test failures.
Sorry, something went wrong.
Comment thread
Lib/importlib/_bootstrap.py
Outdated
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I have made the requested changes; please review again |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks for making the requested changes! @warsaw: please review the changes made to this pull request. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This is going to require implementing exec_module() for zipimport. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecating the use of load_module() requires two parts:
This makes sure that either direct use of the method or indirect use by the import system raises some warning.
The method itself has been documented as deprecated since Python 3.6 and has been superceded by exec_module().
https://bugs.python.org/issue26131