bpo-41919: Avoid resource leak in test_io module - #22973
Merged
pablogsal merged 2 commits intoOct 25, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…void resource leak.
Copy link
Copy Markdown
Member
Author
|
Pls take a look if you have free time, Thanks. @pablogsal @vstinner |
Sorry, something went wrong.
pablogsal
reviewed
Oct 25, 2020
Comment thread
Lib/test/test_io.py
Outdated
pablogsal
approved these changes
Oct 25, 2020
Copy link
Copy Markdown
Member
|
Thanks for the investigation and for the quick fix, @shihai1991! I can confirm that this PR indeed fixes the problem: ❯ ./python -m test test_io -R 3:3 0:00:00 load avg: 4.13 Run tests sequentially 0:00:00 load avg: 4.13 [1/1] test_io beginning 6 repetitions 123456 ...... test_io passed in 3 min 36 sec == Tests result: SUCCESS == 1 test OK. Total duration: 3 min 36 sec Tests result: SUCCESS |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks palbo for review & merge. |
Sorry, something went wrong.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lookupTestDecoder function Split from StatefulIncrementalDecoder to avoid resource leak in test_io module.
https://bugs.python.org/issue41919