FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42171: Add PEP573-related items to the limited API by encukou · Pull Request #23009 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-42171: Add PEP573-related items to the limited API - #23009

Merged
miss-islington merged 5 commits into
python:masterfrom
encukou:pep573-stableabi
Nov 10, 2020
ConversationCommits (5)ChecksFiles changed
Merged

bpo-42171: Add PEP573-related items to the limited API#23009
miss-islington merged 5 commits into
python:masterfrom
encukou:pep573-stableabi

Conversation

encukou commented Oct 27, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue42171

Automerge-Triggered-By: GH:encukou

encukou requested a review from a team as a code owner October 27, 2020 22:08
vstinner reviewed Oct 29, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since PEP 590 has been approved, is there still a reason to exclude METH_FASTCALL from the limited C API? The limited C API is supposed to hide implementation details. Do we still consider that "fastcall" and "vectorcall" are implementation details?

Why not adding METH_FASTCALL to the limited C API, rather than adding a new METH_METHOD_ARGS_KWD macro?

Comment thread Include/methodobject.h Outdated
vstinner reviewed Oct 29, 2020
View reviewed changes
Comment thread PC/python3dll.c

encukou commented Nov 4, 2020

Copy link
Copy Markdown
Member Author

OK! If you're fine adding METH_FASTCALL, I have nothing against it :)

vstinner approved these changes Nov 4, 2020
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks.

@markshannon wrote that "FASTCALL" is a bad name, since there will be faster calling conventions tomorow, but the ship has sailed. Cython uses METH_FASTCALL. It's too late to change it.

When I added METH_FASTCALL, I tried to keep it secret, but Cython started to use the private C API, and here we are :-)

encukou commented Nov 4, 2020

Copy link
Copy Markdown
Member Author

I wouldn't worry that we can't come up with faster-sounding names. Like VictorCall, but that's already taken :)

vstinner commented Nov 4, 2020

Copy link
Copy Markdown
Member

METH_VICTORCALL sounds like a good name :-D

miss-islington merged commit 0b9c4c6 into python:master Nov 10, 2020
encukou deleted the pep573-stableabi branch November 10, 2020 14:03

bedevere-bot commented Nov 10, 2020

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.x has failed when building commit 0b9c4c6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/58/builds/340) and take a look at the build logs.
  4. Check if the failure is related to this commit (0b9c4c6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/58/builds/340

Failed tests:

  • test_peg_generator

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 1        
remote: Enumerating objects: 14, done.        
remote: Counting objects:   7% (1/14)        
remote: Counting objects:  14% (2/14)        
remote: Counting objects:  21% (3/14)        
remote: Counting objects:  28% (4/14)        
remote: Counting objects:  35% (5/14)        
remote: Counting objects:  42% (6/14)        
remote: Counting objects:  50% (7/14)        
remote: Counting objects:  57% (8/14)        
remote: Counting objects:  64% (9/14)        
remote: Counting objects:  71% (10/14)        
remote: Counting objects:  78% (11/14)        
remote: Counting objects:  85% (12/14)        
remote: Counting objects:  92% (13/14)        
remote: Counting objects: 100% (14/14)        
remote: Counting objects: 100% (14/14), done.        
remote: Compressing objects:   9% (1/11)        
remote: Compressing objects:  18% (2/11)        
remote: Compressing objects:  27% (3/11)        
remote: Compressing objects:  36% (4/11)        
remote: Compressing objects:  45% (5/11)        
remote: Compressing objects:  54% (6/11)        
remote: Compressing objects:  63% (7/11)        
remote: Compressing objects:  72% (8/11)        
remote: Compressing objects:  81% (9/11)        
remote: Compressing objects:  90% (10/11)        
remote: Compressing objects: 100% (11/11)        
remote: Compressing objects: 100% (11/11), done.        
remote: Total 14 (delta 3), reused 3 (delta 3), pack-reused 0        
From https://github.com/python/cpython
 * branch                  master     -> FETCH_HEAD
Reset branch 'master'

	not a dynamic executable
/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Modules/_ctypes/callbacks.c: In function ‘_ctypes_alloc_callback’:
/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Modules/_ctypes/callbacks.c:434:9: warning: ‘ffi_prep_closure’ is deprecated: use ffi_prep_closure_loc instead [-Wdeprecated-declarations]
  434 |         result = ffi_prep_closure(p->pcl_write, &p->cif, closure_fcn, p);
      |         ^~~~~~
In file included from /buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Modules/_ctypes/callbacks.c:6:
/usr/lib/libffi/include/ffi.h:334:1: note: declared here
  334 | ffi_prep_closure (ffi_closure*,
      | ^~~~~~~~~~~~~~~~

	not a dynamic executable

Cannot open file '/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/test-results.xml' for upload

encukou commented Nov 10, 2020

Copy link
Copy Markdown
Member Author

The Timeout in test_peg_generator doesn't look related. Will check the next build, https://buildbot.python.org/all/#/builders/58/builds/341

encukou commented Nov 10, 2020

Copy link
Copy Markdown
Member Author

That build first failed (Timeout after 35 minutes), then passed.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-42171: Add PEP573-related items to the limited API (pythonGH-23009)
b94aa0c
vstinner mentioned this pull request Aug 25, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL