FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42232: mmap module add Darwin specific madvise options. by devnexen · Pull Request #23076 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-42232: mmap module add Darwin specific madvise options. - #23076

Merged
miss-islington merged 3 commits into
python:masterfrom
devnexen:mmap_module_upd_for_darwin
Nov 21, 2020
ConversationCommits (3)ChecksFiles changed
Merged

bpo-42232: mmap module add Darwin specific madvise options.#23076
miss-islington merged 3 commits into
python:masterfrom
devnexen:mmap_module_upd_for_darwin

Conversation

devnexen commented Nov 1, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42232

Automerge-Triggered-By: GH:ronaldoussoren

devnexen changed the title mmap module add Darwin specific madvise options. bpo-42232: mmap module add Darwin specific madvise options. Nov 1, 2020
jstasiak approved these changes Nov 2, 2020
View reviewed changes

jstasiak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Works for me on Mac OS 10.14.6:

Python 3.10.0a1+ (remotes/origin/pr/23076:b06ca8b38c28, Nov  2 2020, 20:52:28) 
[Clang 10.0.1 (clang-1001.0.46.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import mmap
>>> mmap.MADV_FREE_REUSABLE
7
>>> mmap.MADV_FREE_REUSE
8

What worries me a little is I couldn't find any documentation on those, but I guess it is what it s. One change I'd make is add these to the MADV_* Constants section in the docs since others are already listed.

devnexen commented Nov 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Works for me on Mac OS 10.14.6:

Python 3.10.0a1+ (remotes/origin/pr/23076:b06ca8b38c28, Nov  2 2020, 20:52:28) 
[Clang 10.0.1 (clang-1001.0.46.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import mmap
>>> mmap.MADV_FREE_REUSABLE
7
>>> mmap.MADV_FREE_REUSE
8

What worries me a little is I couldn't find any documentation on those, but I guess it is what it s. One change I'd make is add these to the MADV_* Constants section in the docs since others are already listed.

It does not appear in the man page (I stumbled across :-)) but the system reports more faithfully the memory usage than MADV_FREE could.

ronaldoussoren approved these changes Nov 21, 2020
View reviewed changes

ronaldoussoren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

miss-islington merged commit 0e62efc into python:master Nov 21, 2020

miss-islington commented Nov 21, 2020

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-42232: mmap module add Darwin specific madvise options. (pythonGH…
bb06532 
…-23076)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ronaldoussoren ronaldoussoren approved these changes
+1 more reviewer
jstasiak jstasiak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OS-mac

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL