bpo-40077: Convert arraymodule to use heap types and establish module state - #23124
Merged
encukou merged 14 commits intoJan 2, 2021
Merged
bpo-40077: Convert arraymodule to use heap types and establish module state#23124encukou merged 14 commits into
encukou merged 14 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
erlend-aasland
marked this pull request as draft
November 3, 2020 13:33
erlend-aasland
force-pushed
the
bpo-40077/array
branch
from
71b9240 to
0de2cfe
Compare
November 3, 2020 13:38
erlend-aasland
marked this pull request as ready for review
November 3, 2020 14:08
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
vstinner
reviewed
Nov 3, 2020
Comment thread
Modules/arraymodule.c
Outdated
added 9 commits
November 3, 2020 23:09
erlend-aasland
force-pushed
the
bpo-40077/array
branch
from
807fcb5 to
5586ddf
Compare
November 3, 2020 22:28
erlend-aasland
force-pushed
the
bpo-40077/array
branch
from
edf3700 to
aa3bd22
Compare
November 3, 2020 22:32
vstinner
reviewed
Nov 4, 2020
Comment thread
Modules/arraymodule.c
Outdated
Copy link
Copy Markdown
Contributor
Author
|
PTAL, @vstinner. I was thinking about including migrating to PyModule_AddObjectRef as well, but I guess we can do that in a separate PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@vstinner Would you mind taking another look at this? |
Sorry, something went wrong.
encukou
approved these changes
Dec 29, 2020
encukou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I do have one nitpick, otherwise the change looks good! Thank you!
Sorry, something went wrong.
Comment thread
Modules/arraymodule.c
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heap types are added to a global state in preparation for module state support.
@corona10 and/or @vstinner, would you mind reviewing this?
https://bugs.python.org/issue40077