| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Remove outdate note about multithreading in sqlite3
Improve wording and formatting in the footnote.
|
Sorry, I am new to this repo, how can I assign "skip news" label? |
Sorry, something went wrong.
AFAIK, someone has to do that for you. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Sorry, something went wrong.
No, it's not! |
Sorry, something went wrong.
|
I am the author. Is anything else required from me? Any concerns? |
Sorry, something went wrong.
|
Anybody? @berkerpeksag, it shows you as code owner... Is there anything that needs to be fixed? |
Sorry, something went wrong.
|
@greatvovan I've been offline for a few weeks. I'll add this to my queue for review. Thanks for your patience. |
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
Revert to mentioning "configure" script.
Keep original lines
|
Thanks @berkerpeksag, I reverted to mentioning configure script and added the link you provided. I insist that the original sentence is bad as it gives no hints to the topic 90% of Python developers will not ever touch. Please also note that the main issue here is removing a paragraph that is inconsistent with other article sections (see BPO), it is not a "random formatting change". |
Sorry, something went wrong.
|
I think it worths to mention that Python must be rebuilt (recompiled) as just running the script will do nothing. |
Sorry, something went wrong.
|
Let me try again. You are trying to make two separate changes in a single PR:
|
Sorry, something went wrong.
Revert back some changes unrelated to the BPO.
There was a problem hiding this comment.
LGTM, thank you!
Sorry, something went wrong.
|
Thanks @greatvovan for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Sorry, something went wrong.
|
Sorry @greatvovan and @berkerpeksag, I had trouble checking out the 3.9 backport branch. |
Sorry, something went wrong.
|
GH-24134 is a backport of this pull request to the 3.8 branch. |
Sorry, something went wrong.
…ythonGH-23159) (cherry picked from commit f9949f8) Co-authored-by: Vladimir <greatvovan@gmail.com>
|
@greatvovan do you have time to submit a backport PR for 3.9? I can help you if you don't want to use cherry_picker. |
Sorry, something went wrong.
My congratulations. |
Sorry, something went wrong.
Yes, I do have time, but your help is appreciated (links, recommendations). Isn't it just a PR to another branch with the same change? |
Sorry, something went wrong.
Yes, you basically do: $ git checkout -b backport-to-3.9 3.9
$ git cherry-pick -x f9949f82e17c88609adb53eff3a7d5cd63a645bd And add [3.9] prefix to PR title when submitting it. You can copy and paste the title of GH-24134 and replace 3.8 with 3.9. |
Sorry, something went wrong.
…ythonGH-23159) (cherry picked from commit f9949f8)
|
GH-24145 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
|
Edit: oh, the bot is faster than me... |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This removes an outdated section in the documentation and slightly improves wording and formatting.
See https://bugs.python.org/issue38413
https://bugs.python.org/issue38413