FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-19561: Remove unnecessary gethostname() prototype for Solaris by kulikjak · Pull Request #23208 · python/cpython · GitHub

/ cpython Public

bpo-19561: Remove unnecessary gethostname() prototype for Solaris - #23208

Closed
kulikjak wants to merge 1 commit into
python:mainfrom
kulikjak:fix-gethostname-declaration
ConversationCommits (1)ChecksFiles changed
Closed

bpo-19561: Remove unnecessary gethostname() prototype for Solaris#23208
kulikjak wants to merge 1 commit into
python:mainfrom
kulikjak:fix-gethostname-declaration

Conversation

kulikjak commented Nov 9, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This is no longer necessary because Solaris included gethostname() in its header files more than 15 years ago.

https://bugs.python.org/issue19561

jstasiak approved these changes Nov 12, 2020
View reviewed changes

jstasiak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just tested this on OpenIndiana, works fine.

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020

kulikjak commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

I cannot remove the stale label, but I am still very interested in this being merged.

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020

github-actions Bot commented Jan 16, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021

kulikjak commented Jan 16, 2021

Copy link
Copy Markdown
Contributor Author

Still relevant...

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jan 17, 2021
kulikjak force-pushed the fix-gethostname-declaration branch 3 times, most recently from 3f551bd to d650b0c Compare August 23, 2022 12:03
iritkatriel requested a review from Yhg1s November 27, 2022 22:52

arhadthedev commented Mar 22, 2023

Copy link
Copy Markdown
Member

@jcea (as an OpenSolaris expert)

kulikjak force-pushed the fix-gethostname-declaration branch from cb868a7 to 93e64c8 Compare May 9, 2023 13:02
kulikjak mentioned this pull request Sep 2, 2023
Merged
kulikjak force-pushed the fix-gethostname-declaration branch from 93e64c8 to d2fc237 Compare September 2, 2023 15:32
risto3 mannequin mentioned this pull request Sep 2, 2023
Closed
vstinner mentioned this pull request Sep 2, 2023
Merged

vstinner commented Sep 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I proposed PR #108817 with more details on the issue.

kulikjak commented Sep 3, 2023

Copy link
Copy Markdown
Contributor Author

Fixed with #108817.

kulikjak closed this Sep 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Yhg1s Awaiting requested review from Yhg1s
1 more reviewer
jstasiak jstasiak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL