FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-85160: Optimized singledispatchmethod access (noticeable improvement). by mental32 · Pull Request #23213 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-85160: Optimized singledispatchmethod access (noticeable improvement). - #23213

Closed
mental32 wants to merge 2 commits into
python:mainfrom
mental32:bpo-40988
ConversationCommits (2)ChecksFiles changed
Closed

gh-85160: Optimized singledispatchmethod access (noticeable improvement).#23213
mental32 wants to merge 2 commits into
python:mainfrom
mental32:bpo-40988

Conversation

mental32 commented Nov 10, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

I benchmarked using the following code:

    from functools import singledispatch, singledispatchmethod
    import timeit

    class Test:
        @singledispatchmethod
        def go(self, item, arg):
            print('general')
        
        @go.register
        def _(self, item:int, arg):
            return item + arg

    @singledispatch
    def go(item, arg):
        print('general')

    @go.register
    def _(item:int, arg):
        return item + arg

    print('m', timeit.timeit('t.go(1, 1)', globals={'t': Test()}))
    print('s', timeit.timeit('go(1, 1)', globals={'go': go}))

And got the following output:

mental@felix ~/D/o/cpython (master)> ./python /tmp/fdsm.py
m 4.794188453000061
s 0.9868643390000216
mental@felix ~/D/o/cpython (master)> git checkout 40988
Switched to branch '40988'
mental@felix ~/D/o/cpython (40988) [1]> ./python /tmp/fdsm.py
m 1.3791182540007867
s 0.9882650030003788

I'm still curious if access could be further optimized clueless when it comes to ideas 😅

https://bugs.python.org/issue40988

mental32 requested a review from rhettinger as a code owner November 10, 2020 05:12
mental32 changed the title bpo-40988: Optimized singledispatchmethod access (3x ish improvement). bpo-40988: Optimized singledispatchmethod access (noticeable improvement). Nov 10, 2020

CaselIT commented Nov 10, 2020

Copy link
Copy Markdown

Thanks for taking this up!

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020

CaselIT commented Dec 16, 2020

Copy link
Copy Markdown

Comment to avoid closure

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020

github-actions Bot commented Jan 16, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021

mental32 commented Jan 16, 2021

Copy link
Copy Markdown
Contributor Author

@rhettinger sorry for bothering you but do you have enough bandwidth to review this or can you defer to someone else?

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jan 17, 2021

CaselIT commented Sep 17, 2021

Copy link
Copy Markdown

Not sure if there is anything we should do to allow this to be reviewed

rhettinger removed their request for review May 3, 2022 06:14
MaxwellDupre approved these changes May 14, 2022
View reviewed changes

MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

On my slow system more modest, but an improvement:
11.24
2.27
to
5.83
3.54
I not that this is built on 3.10.0a2+ so there maybe further speed improvements when 3.11/3.12 is released. So a worthwhile change.

TeamSpen210 commented May 14, 2022

Copy link
Copy Markdown

Since this is something that’ll have observable effects on objects, should this be documented? If you’re introspecting your objects, or are say concerned about memory usage it might be surprising behaviour.

eendebakpt mentioned this pull request Aug 31, 2022
Closed
iritkatriel added the performance Performance or resource usage label Aug 31, 2022
CaselIT mannequin mentioned this pull request Sep 9, 2022
Closed
AlexWaygood changed the title bpo-40988: Optimized singledispatchmethod access (noticeable improvement). gh-85160: Optimized singledispatchmethod access (noticeable improvement). Jul 5, 2023
AlexWaygood mentioned this pull request Jul 5, 2023
Closed

eendebakpt commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

@mental32 @AlexWaygood By accident I created an independent implementation of the singledispatchmethod improvement. In #106448 I added a performance comparison of this PR and the other one. I also added a test for the case of a class with slots (commit 4e068d4). Feel free to pull that one into this branch.

Both branches give a performance improvement over current main. Hopefully one of them gets accepted.

eendebakpt reviewed Jul 5, 2023
View reviewed changes
Comment thread Lib/functools.py
Comment on lines +957 to +963
if self.attrname is not None:
attrname = self.attrname

try:
obj.__dict__[attrname] = _method
except AttributeError:
pass # not all objects have __dict__ (e.g. class defines slots)

eendebakpt Jul 5, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
if self.attrname is not None:
attrname = self.attrname
try:
obj.__dict__[attrname] = _method
except AttributeError:
pass # not all objects have __dict__ (e.g. class defines slots)
if self.attrname is not None:
try:
obj.__dict__[self.attrname] = _method
except AttributeError:
pass # not all objects have __dict__ (e.g. class defines slots)

corona10 self-assigned this Jul 21, 2023
eendebakpt mentioned this pull request Jul 23, 2023
Merged

mental32 commented Jul 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@eendebakpt thank you for continuing with this!

for any changes or merging that you would like to see done is it okay for me to say "do whatever you need to do :)" and defer to you? (including closing this PR if the other one is sufficient in perf improvements) I don't think I have the time to pay attention to this is all

AlexWaygood commented Aug 6, 2023

Copy link
Copy Markdown
Member

Closing in favour of #107148 (in which you have been listed as a co-author :)

AlexWaygood closed this Aug 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eendebakpt eendebakpt left review comments
+1 more reviewer
MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

corona10

Labels

awaiting core review performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL