bpo-42246: Fix memory leak in compiler - #23256
Merged
markshannon merged 2 commits intoNov 13, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I didn't look at the diff, but I confirm that this PR fix the issue that I reported: $ ./python -m test -R 3:3 -j0 test_asyncgen test_builtin test_coroutines test_exceptions test_syntax ... Tests result: SUCCESS |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 55d9d2b 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
* Fix potential memory leak in assembler init. * Fix reference leak when encountering error during compilation of function body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual memory leak fix is the change on line 2279.
It looks like assemble_init could potentially leak as well, so I've fixed that as well.
https://bugs.python.org/issue42246