FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42374: Allow unparenthesized walrus in genexps by lysnikolaou · Pull Request #23319 · python/cpython · GitHub

/ cpython Public

bpo-42374: Allow unparenthesized walrus in genexps - #23319

Merged
miss-islington merged 3 commits into
python:masterfrom
lysnikolaou:unparenthesized-walrus-genexp
Nov 16, 2020
ConversationCommits (3)ChecksFiles changed
Merged

bpo-42374: Allow unparenthesized walrus in genexps#23319
miss-islington merged 3 commits into
python:masterfrom
lysnikolaou:unparenthesized-walrus-genexp

Conversation

lysnikolaou commented Nov 16, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

This fixes a regression that was introduced by the new parser.

https://bugs.python.org/issue42374

Automerge-Triggered-By: GH:lysnikolaou

bpo-42374: Allow unparenthesized walrus in genexps
1f188e4 
This fixes a regression that was introduced by the new parser.
pablogsal approved these changes Nov 16, 2020
View reviewed changes

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch! 🎣

pablogsal reviewed Nov 16, 2020
View reviewed changes
Comment thread Lib/test/test_named_expressions.py Outdated

pablogsal commented Nov 16, 2020

Copy link
Copy Markdown
Member

How did you find this? 🤔

lysnikolaou commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

How did you find this?

@terryjreedy found it while working on #23291.

miss-islington commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

@lysnikolaou: Status check is done, and it's a success ✅ .

miss-islington merged commit cb3e5ed into python:master Nov 16, 2020

miss-islington commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

Sorry, @lysnikolaou, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cb3e5ed0716114393696ec7201e51fe0595eab4f 3.9

miss-islington self-assigned this Nov 16, 2020
lysnikolaou deleted the unparenthesized-walrus-genexp branch November 16, 2020 23:09
lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Nov 16, 2020
bpo-42374: Allow unparenthesized walrus in genexps (pythonGH-23319)
5244e21 
This fixes a regression that was introduced by the new parser.

(cherry picked from commit cb3e5ed)

bedevere-bot commented Nov 16, 2020

Copy link
Copy Markdown

GH-23329 is a backport of this pull request to the 3.9 branch.

lysnikolaou mentioned this pull request Nov 16, 2020
Merged
lysnikolaou added a commit that referenced this pull request Nov 16, 2020
bpo-42374: Allow unparenthesized walrus in genexps (GH-23319) (GH-23329)
2b800ef 
This fixes a regression that was introduced by the new parser.

(cherry picked from commit cb3e5ed)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-42374: Allow unparenthesized walrus in genexps (pythonGH-23319)
69434fb 
This fixes a regression that was introduced by the new parser.

Automerge-Triggered-By: GH:lysnikolaou
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes
terryjreedy Awaiting requested review from terryjreedy
gvanrossum Awaiting requested review from gvanrossum

Assignees

miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL