Repository navigation
[3.9] bpo-42345: Fix three issues with typing.Literal parameters (GH-23294) - #23335
Merged
miss-islington merged 1 commit intoNov 17, 2020
Merged
miss-islington merged 1 commit into
miss-islington merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…honGH-23294) Literal equality no longer depends on the order of arguments. Fix issue related to `typing.Literal` caching by adding `typed` parameter to `typing._tp_cache` function. Add deduplication of `typing.Literal` arguments.. (cherry picked from commit f03d318) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
gvanrossum
approved these changes
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Literal equality no longer depends on the order of arguments.
Fix issue related to typing.Literal caching by adding typed parameter to typing._tp_cache function.
Add deduplication of typing.Literal arguments.
(cherry picked from commit f03d318)
Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com
https://bugs.python.org/issue42345
Automerge-Triggered-By: GH:gvanrossum