FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41861: Add NEWS and normalise _sqlite3 Cache/Node type struct naming by erlend-aasland · Pull Request #23337 · python/cpython · GitHub

/ cpython Public

bpo-41861: Add NEWS and normalise _sqlite3 Cache/Node type struct naming - #23337

Merged
vstinner merged 3 commits into
python:masterfrom
erlend-aasland:bpo-41861/final
Nov 17, 2020
ConversationCommits (3)ChecksFiles changed
Merged

bpo-41861: Add NEWS and normalise _sqlite3 Cache/Node type struct naming#23337
vstinner merged 3 commits into
python:masterfrom
erlend-aasland:bpo-41861/final

Conversation

erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor Author

@corona10 Would you mind taking a quick look at this? Just closing bpo-41861 by adding a NEWS entry and normalising Cache/Node struct names (so that the naming is consistent with the other type structs in _sqlite3.)

(I closed #22419, since it went in limbo.)

corona10 reviewed Nov 17, 2020
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@erlend-aasland

Can you provide a discussion about normalizing?
we often do not accept this kind of PR ;)

erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor Author

Can you provide a discussion about normalizing?
we often do not accept this kind of PR ;)

Yes, I'm aware of that, but since this is the final PR of bpo-41861, I thought an exception would be acceptable, since the other PR's relating to this bpo have used this naming scheme ;) Please? :)

Fix punctuation mark in NEWS entry
f268153 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner merged commit 2ffba2a into python:master Nov 17, 2020

vstinner commented Nov 17, 2020

Copy link
Copy Markdown
Member

Merged. I rewrote your commit message to make it shorter.

erlend-aasland deleted the bpo-41861/final branch November 17, 2020 13:32
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-41861, _sqlite3 : Add NEWS entry and rename variables (pythonGH-2…
b989296 
…3337)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments
corona10 corona10 left review comments
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL