FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 by erlend-aasland · Pull Request #23341 · python/cpython · GitHub

/ cpython Public

bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 - #23341

Merged
corona10 merged 3 commits into
python:masterfrom
erlend-aasland:bpo-40956/part2a-con
Dec 18, 2020
ConversationCommits (3)ChecksFiles changed
Merged

bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2#23341
corona10 merged 3 commits into
python:masterfrom
erlend-aasland:bpo-40956/part2a-con

Conversation

erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland commented Nov 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@corona10: As proposed on #23057, I've split that PR up in two parts. This is the first, and larger (by line count) part, however probably the easiest to review, as the AC conversion is straight-forward.

This was referenced Nov 17, 2020
Merged
Closed

erlend-aasland commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

@corona10 Have you had time to look at this? Let me know if still think it's too large for a single review.

corona10 self-requested a review December 17, 2020 10:40

corona10 commented Dec 17, 2020

Copy link
Copy Markdown
Member

@erlend-aasland I will take a look ;)

erlend-aasland commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

@corona10 Thank you :) 🙏🏻

corona10 requested changes Dec 18, 2020
View reviewed changes
Comment thread Modules/_sqlite/connection.c

bedevere-bot commented Dec 18, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

erlend-aasland commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Dec 18, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

corona10 reviewed Dec 18, 2020
View reviewed changes
Comment thread Modules/_sqlite/connection.c
corona10 approved these changes Dec 18, 2020
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM except for nit comment ;)

erlend-aasland commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

LGTM except for nit comment ;)

I appreciate a thorough review! :) PTAL

corona10 merged commit 1ba82bb into python:master Dec 18, 2020
serhiy-storchaka reviewed Dec 18, 2020
View reviewed changes
Comment thread Modules/_sqlite/connection.c
Comment thread Modules/_sqlite/connection.c
corona10 mentioned this pull request Dec 18, 2020
Merged
erlend-aasland deleted the bpo-40956/part2a-con branch December 18, 2020 15:36
erlend-aasland mentioned this pull request Dec 30, 2020
Merged
erlend-aasland mentioned this pull request Feb 9, 2021
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-40956: Convert _sqlite3.Connection to Argument Clinic (pythonGH-2…
7f94211 
…3341)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments
corona10 corona10 approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL