FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40137: Convert _functools module to use PyType_FromModuleAndSpec. by shihai1991 · Pull Request #23405 · python/cpython · GitHub

/ cpython Public

bpo-40137: Convert _functools module to use PyType_FromModuleAndSpec. - #23405

Merged
miss-islington merged 8 commits into
python:masterfrom
shihai1991:bpo_40137_functools2
Dec 29, 2020
ConversationCommits (8)ChecksFiles changed
Merged

bpo-40137: Convert _functools module to use PyType_FromModuleAndSpec.#23405
miss-islington merged 8 commits into
python:masterfrom
shihai1991:bpo_40137_functools2

Conversation

shihai1991 commented Nov 19, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40137

Automerge-Triggered-By: GH:encukou

vstinner reviewed Nov 19, 2020
View reviewed changes
Comment thread Modules/_pickle.c Outdated
tiran previously requested changes Nov 20, 2020
View reviewed changes
Comment thread Modules/_functoolsmodule.c Outdated
Comment thread Modules/_functoolsmodule.c Outdated

bedevere-bot commented Nov 20, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

shihai1991 commented Nov 24, 2020
View reviewed changes
Comment thread Lib/test/test_functools.py

shihai1991 commented Nov 24, 2020

Copy link
Copy Markdown
Member Author

@corona10 Hi, Dong-hee Na. Can you take a look of this PR? Thanks.

encukou reviewed Dec 15, 2020
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This can be simplified; we don't need to use the module state as heavily.

Comment thread Modules/_functoolsmodule.c Outdated
Comment thread Modules/_functoolsmodule.c Outdated
Comment thread Modules/_functoolsmodule.c Outdated
encukou dismissed tiran’s stale review December 29, 2020 12:44

The requested changes were made.

encukou approved these changes Dec 29, 2020
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! Thank you!

miss-islington merged commit dd39123 into python:master Dec 29, 2020

shihai1991 commented Dec 29, 2020

Copy link
Copy Markdown
Member Author

Thanks petr for your review and merge.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-40137: Convert _functools module to use PyType_FromModuleAndSpec. (…
d26154c 
…pythonGH-23405)
sobolevn mentioned this pull request Sep 7, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes
tiran tiran left review comments
rhettinger Awaiting requested review from rhettinger
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL