Repository navigation
[3.9] bpo-42345: Fix hash implementation of typing.Literal (GH-23383) - #23408
Merged
miss-islington merged 1 commit intoNov 19, 2020
Merged
miss-islington merged 1 commit into
miss-islington merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fix hash implementation of `typing.Literal`. Update docs regarding `typing.Litaral` caching. Base implementation was done in PR pythonGH-23294. (cherry picked from commit 1b54077) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
miss-islington
requested review from
gvanrossum and
ilevkivskyi
as code owners
November 19, 2020 16:17
Copy link
Copy Markdown
Contributor
Author
|
@uriyyo: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@uriyyo: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
gvanrossum
approved these changes
Nov 19, 2020
Copy link
Copy Markdown
Contributor
Author
|
@uriyyo: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@uriyyo: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix hash implementation of typing.Literal.
Update docs regarding typing.Litaral caching.
Base implementation was done in PR GH-23294.
(cherry picked from commit 1b54077)
Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com
https://bugs.python.org/issue42345