Repository navigation
bpo-42212: smelly.py also checks the dynamic library - #23423
Merged
vstinner merged 3 commits intoNov 24, 2020
Merged
vstinner merged 3 commits into
vstinner merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I rebase my PR on top of d20b7ed to get the updated GHA action.
https://github.com/python/cpython/pull/23423/checks?check_run_id=1431368524 /python Tools/scripts/smelly.py Check that libpython3.10d.a only exports symbols starting with Py or _Py + nm -p libpython3.10d.a Ignored symbol types: b, d, r, t OK: no smelly symbol found |
Sorry, something went wrong.
The smelly.py script now also checks the Python dynamic library and extension modules, not only the Python static library. Make also the script more verbose: explain what it does. The GitHub Action job now builds Python with the libpython dynamic library.
Copy link
Copy Markdown
Member
Author
|
Hum, make smelly fails on Ubuntu (" Tests / Check if generated files are up to date" job): Smelly symbol: _fini (type: T) Smelly symbol: _init (type: T) ERROR: Found 2 smelly symbols! |
Sorry, something went wrong.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
The smelly.py script now also checks the Python dynamic library and extension modules, not only the Python static library. Make also the script more verbose: explain what it does. The GitHub Action job now builds Python with the libpython dynamic library.
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Nov 11, 2025
These exceptions were added in python#23423
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Nov 11, 2025
These exceptions were added in python#23423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smelly.py script now also checks the Python dynamic library, not
only the Python static library. Make also the script more verbose:
explain what it does.
https://bugs.python.org/issue42212