bpo-29176 Use tmpfile() in curses module - #235
Conversation
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
Oh, I missed your PR and wrote exactly the same :-)
Sorry, something went wrong.
There was a problem hiding this comment.
the if can now be removed
Sorry, something went wrong.
There was a problem hiding this comment.
= NULL can be removed
Same remarks for the other function.
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
Sorry, something went wrong.
There was a problem hiding this comment.
Can be OSError.
Sorry, something went wrong.
|
I think an entry in Misc/NEWS is required. |
Sorry, something went wrong.
From an user point of view, there is no change, except of Android support. Last days, I'm trying to avoid touching Misc/NEWS, because it's even more a mess because of how pull requests work :-( |
Sorry, something went wrong.
The curses module used mkstemp() + fopen() to create a temporary file in /tmp. The /tmp directory does not exist on Android. The tmpfile() function simplifies the task a lot. It creates a temporary file in a correct directory, takes care of cleanup and returns FILE*. tmpfile is supported on all platforms (C89, POSIX 2001, Android, Windows). Signed-off-by: Christian Heimes <christian@python.org>
…#188 This commit fixes an assert statement, that could fail since python#188. No functional change. (cherry picked from commit 5595eec)
…#188 This commit fixes an assert statement, that could fail since python#188. No functional change.
Bumps [cherry-picker](https://github.com/python/core-workflow) from 1.2.2 to 1.3.2. - [Release notes](https://github.com/python/core-workflow/releases) - [Commits](python/core-workflow@cherry-picker-v1.2.2...cherry-picker-v1.3.2)
The curses module used mkstemp() + fopen() to create a temporary file in
/tmp. The /tmp directory does not exist on Android. The tmpfile()
function simplifies the task a lot. It creates a temporary file in a
correct directory, takes care of cleanup and returns FILE*.
tmpfile is supported on all platforms (C89, POSIX 2001, Android,
Windows).
https://bugs.python.org/issue29176
Signed-off-by: Christian Heimes christian@python.org