FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] bpo-42482: remove reference to exc_traceback from TracebackException (GH-23531) by miss-islington · Pull Request #23578 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.9] bpo-42482: remove reference to exc_traceback from TracebackException (GH-23531) #23578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Dec 4, 2020
Conversation 2 Commits 1 Checks 0 Files changed
Merged

[3.9] bpo-42482: remove reference to exc_traceback from TracebackException (GH-23531) #23578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (2) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
22 changes: 22 additions & 0 deletions Lib/test/test_traceback.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1103,6 +1103,18 @@ def test_context(self):
self.assertEqual(exc_info[0], exc.exc_type)
self.assertEqual(str(exc_info[1]), str(exc))

def test_no_refs_to_exception_and_traceback_objects(self):
try:
1/0
except Exception:
exc_info = sys.exc_info()

refcnt1 = sys.getrefcount(exc_info[1])
refcnt2 = sys.getrefcount(exc_info[2])
exc = traceback.TracebackException(*exc_info)
self.assertEqual(sys.getrefcount(exc_info[1]), refcnt1)
self.assertEqual(sys.getrefcount(exc_info[2]), refcnt2)

def test_comparison_basic(self):
try:
1/0
Expand Down Expand Up @@ -1152,6 +1164,16 @@ def raise_with_locals():
exc7 = traceback.TracebackException(*exc_info, limit=-2, capture_locals=True)
self.assertNotEqual(exc6, exc7)

def test_comparison_equivalent_exceptions_are_equal(self):
excs = []
for _ in range(2):
try:
1/0
except:
excs.append(traceback.TracebackException(*sys.exc_info()))
self.assertEqual(excs[0], excs[1])
self.assertEqual(list(excs[0].format()), list(excs[1].format()))

def test_unhashable(self):
class UnhashableException(Exception):
def __eq__(self, other):
Expand Down
5 changes: 2 additions & 3 deletions Lib/traceback.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,6 @@ def __init__(self, exc_type, exc_value, exc_traceback, *, limit=None,
_seen=_seen)
else:
context = None
self.exc_traceback = exc_traceback
self.__cause__ = cause
self.__context__ = context
self.__suppress_context__ = \
Expand Down Expand Up @@ -617,7 +616,7 @@ def format(self, *, chain=True):
not self.__suppress_context__):
yield from self.__context__.format(chain=chain)
yield _context_message
if self.exc_traceback is not None:
if self.stack:
yield 'Traceback (most recent call last):\n'
yield from self.stack.format()
yield from self.stack.format()
yield from self.format_exception_only()
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2020-11-27-16-46-58.bpo-42482.EJC3sd.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:class:`~traceback.TracebackException` no longer holds a reference to the exception's traceback object. Consequently, instances of TracebackException for equivalent but non-equal exceptions now compare as equal.
Back | FazBrowse Home | New Git URL