Repository navigation
bpo-17735: make inspect.findsource raise OsError instead of IndexError wh… - #23633
Merged
taleinat merged 3 commits intoDec 4, 2020
Merged
taleinat merged 3 commits into
taleinat merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…en co_lineno is larger than length of file (can happen if file was updated since import)
iritkatriel
force-pushed
the
bpo-17735
branch
from
07bbd9c to
497385a
Compare
December 4, 2020 17:10
taleinat
approved these changes
Dec 4, 2020
taleinat
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @iritkatriel for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @iritkatriel for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 4, 2020
…t of range (pythonGH-23633) This can happen when a file was edited after it was imported. (cherry picked from commit 2e0760b) Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
Copy link
Copy Markdown
|
GH-23646 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 4, 2020
…t of range (pythonGH-23633) This can happen when a file was edited after it was imported. (cherry picked from commit 2e0760b) Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
Copy link
Copy Markdown
|
GH-23647 is a backport of this pull request to the 3.8 branch. |
Sorry, something went wrong.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…t of range (pythonGH-23633) This can happen when a file was edited after it was imported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…en co_lineno is larger than length of file (can happen if file was updated since import)
The docstring says this function raises OSError when it can't find the source, so we make it so.
(The bpo is about the consequence of help() not handling IndexError.)
https://bugs.python.org/issue17735