Repository navigation
bpo-32381: Fix PyRun_SimpleFileExFlags() encoding - #23642
Merged
vstinner merged 1 commit intoDec 8, 2020
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@FFY00: Hey, the "Check if generated files are up to date" worked as expected! It spotted a bug in my PR (already fixed): Check that libpython3.10d.a only exports symbols starting with Py or _Py + nm --no-sort libpython3.10d.a Ignore 20161 local symbols Smelly symbol: pyrun_simple_file (type: T) ERROR: Found 1 smelly symbols! Thanks again for this nice new GitHub Action job ;-) |
Sorry, something went wrong.
izbyshev
reviewed
Dec 4, 2020
Comment thread
Python/pythonrun.c
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
arena can't be NULL here anymore.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Oh right, fixed, thanks ;-)
Sorry, something went wrong.
Fix encoding name when running a ".pyc" file on Windows: PyRun_SimpleFileExFlags() now uses the correct encoding to decode the filename. * Add pyrun_file() subfunction. * Add pyrun_simple_file() subfunction. * PyRun_SimpleFileExFlags() now calls _Py_fopen_obj() rather than _Py_fopen().
Copy link
Copy Markdown
Member
Author
|
Strange. I pushed a fix for if (arena != NULL) but I cannot see yet. I guess that it will appear on the website soon. |
Sorry, something went wrong.
vstinner
added a commit
that referenced
this pull request
Dec 8, 2020
Fix encoding name when running a ".pyc" file on Windows: PyRun_SimpleFileExFlags() now uses the correct encoding to decode the filename. * Add pyrun_file() subfunction. * Add pyrun_simple_file() subfunction. * PyRun_SimpleFileExFlags() now calls _Py_fopen_obj() rather than _Py_fopen(). (cherry picked from commit b6d98c1)
vstinner
added a commit
that referenced
this pull request
Dec 8, 2020
… (GH-23696) Fix encoding name when running a ".pyc" file on Windows: PyRun_SimpleFileExFlags() now uses the correct encoding to decode the filename. * Add pyrun_file() subfunction. * Add pyrun_simple_file() subfunction. * PyRun_SimpleFileExFlags() now calls _Py_fopen_obj() rather than _Py_fopen(). (cherry picked from commit b6d98c1) (cherry picked from commit f0e42ae)
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Fix encoding name when running a ".pyc" file on Windows: PyRun_SimpleFileExFlags() now uses the correct encoding to decode the filename. * Add pyrun_file() subfunction. * Add pyrun_simple_file() subfunction. * PyRun_SimpleFileExFlags() now calls _Py_fopen_obj() rather than _Py_fopen().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix encoding name when running a ".pyc" file on Windows:
PyRun_SimpleFileExFlags() now uses the correct encoding to decode the
filename.
_Py_fopen().
https://bugs.python.org/issue32381